mirror of
https://github.com/nektos/act.git
synced 2026-04-26 01:15:51 +03:00
[PR #288] [MERGED] remove .gitignore before docker cp #1403
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#1403
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/nektos/act/pull/288
Author: @o0Ignition0o
Created: 6/21/2020
Status: ✅ Merged
Merged: 6/23/2020
Merged by: @cplee
Base:
master← Head:igni/remove_gitignore_before_cp📝 Commits (2)
c5c167dTest setup before I try to understand how things work16c8f94Remove .gitignore before we run docker cp📊 Changes
3 files changed (+38 additions, -1 deletions)
View changed files
📝
pkg/runner/runner_test.go(+1 -0)📝
pkg/runner/step_context.go(+23 -1)➕
pkg/runner/testdata/issue-228/main.yaml(+14 -0)📄 Description
Will hopefully fix #228
This patch checks for the presence of a
.gitignorefile in a remote repository action, and removes it before runningdocker cp.I'm not too aware of how the project works and its structure, I'm not even sure that's the way you'd like to address this issue, so please let me know how you feel about it, and feel free to discard it or ask me for edits :)
Thanks again for your time
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.