[PR #243] [MERGED] Fix using: node12 handling #1396

New issue

Closed

opened 2026-03-01 21:51:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/243
Author: @jsoref
Created: 5/17/2020
Status: ✅ Merged
Merged: 5/18/2020
Merged by: @cplee

Base: master ← Head: node12

📝 Commits (2)

5a998b6 Fix using: node12 handling
de23609 Merge branch 'master' into node12

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 pkg/runner/step_context.go (+2 -1)

📄 Description

This probably fixes #220

When I use 2f3187ebcd (or act version 0.2.8 from brew) with:
github.com/check-spelling/check-spelling@5f7f35b25e
I get:

$ act -b -v 2>&1 |grep -A10 'About to run action'
time="2020-05-17T08:12:32-04:00" level=debug msg="About to run action &{Check spelling jsoref Spell check commits map[bucket:{Container for spelling configuration true } debug:{Debug false } project:{Folder/Branch within bucket containing spelling configuration true } repo-token:{The GITHUB_TOKEN secret false }] map[] {node12 map[] trampoline.js  [] []} {red edit-3}}"
time="2020-05-17T08:12:32-04:00" level=debug msg="type=2 actionDir=/Users/jsoref/code/spelling-org/check-spelling.git Workdir=/Users/jsoref/code/spelling-org/check-spelling.git ActionCacheDir=/Users/jsoref/.cache/act actionName=check-spelling.git containerActionDir=/github/workspace"
[Spell checking/Spell checker] Exec command '[node /github/workspace/check-spelling.git/trampoline.js]'
[Spell checking/Spell checker]   | internal/modules/cjs/loader.js:628
[Spell checking/Spell checker]   |     throw err;
[Spell checking/Spell checker]   |     ^
[Spell checking/Spell checker]   |
[Spell checking/Spell checker]   | Error: Cannot find module '/github/workspace/check-spelling.git/trampoline.js'
[Spell checking/Spell checker]   |     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:625:15)
[Spell checking/Spell checker]   |     at Function.Module._load (internal/modules/cjs/loader.js:527:27)
[Spell checking/Spell checker]   |     at Function.Module.runMain (internal/modules/cjs/loader.js:839:10)

With this change, I get:

$ ~/code/nektos/act/dist/local/act -v -b 2>&1|grep -A10 'About to run action'
time="2020-05-17T08:14:12-04:00" level=debug msg="About to run action &{Check spelling jsoref Spell check commits map[bucket:{Container for spelling configuration true } debug:{Debug false } project:{Folder/Branch within bucket containing spelling configuration true } repo-token:{The GITHUB_TOKEN secret false }] map[] {node12 map[] trampoline.js  [] []} {red edit-3}}"
time="2020-05-17T08:14:12-04:00" level=debug msg="type=2 actionDir=/Users/jsoref/code/spelling-org/check-spelling.git Workdir=/Users/jsoref/code/spelling-org/check-spelling.git ActionCacheDir=/Users/jsoref/.cache/act actionName=check-spelling.git containerActionDir=/github/workspace"
[Spell checking/Spell checker] Exec command '[node /github/workspace/trampoline.js]'
[Spell checking/Spell checker]   | cwd: /github/workspace
[Spell checking/Spell checker]   | spellchecker: /github/workspace
[Spell checking/Spell checker]   ❓  ::add-matcher::.git/reporter.json
[Spell checking/Spell checker]   | Retrieving expect from .github/actions/spelling/expect/Dockerfile.txt
[Spell checking/Spell checker]   | .github/actions/spelling/expect/README.md.txt
[Spell checking/Spell checker]   | .github/actions/spelling/expect/action.yml.txt
[Spell checking/Spell checker]   | .github/actions/spelling/expect/check-pull-requests.sh.txt
[Spell checking/Spell checker]   | .github/actions/spelling/expect/common.sh.txt

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/243 **Author:** [@jsoref](https://github.com/jsoref) **Created:** 5/17/2020 **Status:** ✅ Merged **Merged:** 5/18/2020 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `node12` --- ### 📝 Commits (2) - [`5a998b6`](https://github.com/nektos/act/commit/5a998b6210148eceb4ea6168081d28f600a5d745) Fix using: node12 handling - [`de23609`](https://github.com/nektos/act/commit/de236090e7fa2101f09f3bf9da1f6657d0960dae) Merge branch 'master' into node12 ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/step_context.go` (+2 -1) </details> ### 📄 Description This probably fixes #220 When I use 2f3187ebcd5e4bb64862e0df2af181771858011e (or act version 0.2.8 from brew) with: https://github.com/check-spelling/check-spelling/commit/5f7f35b25e6bce7b1e5a8f226369a86ab19a623e I get: ```node $ act -b -v 2>&1 |grep -A10 'About to run action' time="2020-05-17T08:12:32-04:00" level=debug msg="About to run action &{Check spelling jsoref Spell check commits map[bucket:{Container for spelling configuration true } debug:{Debug false } project:{Folder/Branch within bucket containing spelling configuration true } repo-token:{The GITHUB_TOKEN secret false }] map[] {node12 map[] trampoline.js [] []} {red edit-3}}" time="2020-05-17T08:12:32-04:00" level=debug msg="type=2 actionDir=/Users/jsoref/code/spelling-org/check-spelling.git Workdir=/Users/jsoref/code/spelling-org/check-spelling.git ActionCacheDir=/Users/jsoref/.cache/act actionName=check-spelling.git containerActionDir=/github/workspace" [Spell checking/Spell checker] Exec command '[node /github/workspace/check-spelling.git/trampoline.js]' [Spell checking/Spell checker] | internal/modules/cjs/loader.js:628 [Spell checking/Spell checker] | throw err; [Spell checking/Spell checker] | ^ [Spell checking/Spell checker] | [Spell checking/Spell checker] | Error: Cannot find module '/github/workspace/check-spelling.git/trampoline.js' [Spell checking/Spell checker] | at Function.Module._resolveFilename (internal/modules/cjs/loader.js:625:15) [Spell checking/Spell checker] | at Function.Module._load (internal/modules/cjs/loader.js:527:27) [Spell checking/Spell checker] | at Function.Module.runMain (internal/modules/cjs/loader.js:839:10) ``` With this change, I get: ```node $ ~/code/nektos/act/dist/local/act -v -b 2>&1|grep -A10 'About to run action' time="2020-05-17T08:14:12-04:00" level=debug msg="About to run action &{Check spelling jsoref Spell check commits map[bucket:{Container for spelling configuration true } debug:{Debug false } project:{Folder/Branch within bucket containing spelling configuration true } repo-token:{The GITHUB_TOKEN secret false }] map[] {node12 map[] trampoline.js [] []} {red edit-3}}" time="2020-05-17T08:14:12-04:00" level=debug msg="type=2 actionDir=/Users/jsoref/code/spelling-org/check-spelling.git Workdir=/Users/jsoref/code/spelling-org/check-spelling.git ActionCacheDir=/Users/jsoref/.cache/act actionName=check-spelling.git containerActionDir=/github/workspace" [Spell checking/Spell checker] Exec command '[node /github/workspace/trampoline.js]' [Spell checking/Spell checker] | cwd: /github/workspace [Spell checking/Spell checker] | spellchecker: /github/workspace [Spell checking/Spell checker] ❓ ::add-matcher::.git/reporter.json [Spell checking/Spell checker] | Retrieving expect from .github/actions/spelling/expect/Dockerfile.txt [Spell checking/Spell checker] | .github/actions/spelling/expect/README.md.txt [Spell checking/Spell checker] | .github/actions/spelling/expect/action.yml.txt [Spell checking/Spell checker] | .github/actions/spelling/expect/check-pull-requests.sh.txt [Spell checking/Spell checker] | .github/actions/spelling/expect/common.sh.txt ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:00 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1396

No description provided.

Rows
Columns