[PR #231] [MERGED] Mask secrets in job output #1389

New issue

Closed

opened 2026-03-01 21:50:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:50:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/231
Author: @mheap
Created: 5/11/2020
Status: ✅ Merged
Merged: 5/13/2020
Merged by: @cplee

Base: master ← Head: add-secret-masking

📝 Commits (3)

4722598 Mask secrets in job output
0c11089 Merge branch 'master' into add-secret-masking
d2048e6 Merge branch 'master' into add-secret-masking

📊 Changes

2 files changed (+10 additions, -3 deletions)

View changed files

📝 pkg/runner/logger.go (+9 -2)
📝 pkg/runner/runner.go (+1 -1)

📄 Description

Previously secrets would be shown in log output as provided. This
commit updates the stepLogFormatter to replace any instance of the secret
string with "***", as GitHub Actions would

Known issues: If the secret is a generic string (such as "docker"), all
occurances of that string will be replaced in the output

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/231 **Author:** [@mheap](https://github.com/mheap) **Created:** 5/11/2020 **Status:** ✅ Merged **Merged:** 5/13/2020 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `add-secret-masking` --- ### 📝 Commits (3) - [`4722598`](https://github.com/nektos/act/commit/47225987b1d5f77761bbbfb68a9f7c71527ecef6) Mask secrets in job output - [`0c11089`](https://github.com/nektos/act/commit/0c110890d59faf7bcc2945aa2fef40ab0fd1109e) Merge branch 'master' into add-secret-masking - [`d2048e6`](https://github.com/nektos/act/commit/d2048e608b56ba5c01bd4dbd2df331b91473bc9b) Merge branch 'master' into add-secret-masking ### 📊 Changes **2 files changed** (+10 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/logger.go` (+9 -2) 📝 `pkg/runner/runner.go` (+1 -1) </details> ### 📄 Description Previously secrets would be shown in log output as provided. This commit updates the stepLogFormatter to replace any instance of the secret string with "***", as GitHub Actions would Known issues: If the secret is a generic string (such as "docker"), all occurances of that string will be replaced in the output --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:50:58 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1389

No description provided.

Rows
Columns