[PR #190] [MERGED] Remove length constraint for container names #1380

New issue

Closed

opened 2026-03-01 21:50:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:50:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/190
Author: @albertofem
Created: 4/13/2020
Status: ✅ Merged
Merged: 4/16/2020
Merged by: @cplee

Base: master ← Head: feature/remove_length_constraint

📝 Commits (1)

2988e7f Remove length constraint

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 pkg/runner/run_context.go (+1 -1)

📄 Description

There is a 30 length hardcoded limit for containers name, which makes matrix builds with long job names unable to run due to conflicting container names (see https://github.com/nektos/act/issues/174)

Apparently docker does not imposes a constraint in the length of the container name, as seen in the engine code: https://github.com/docker/engine/blob/master/daemon/names.go#L59

Tested with Docker version 19.03.8, build afacb8b

Not sure if in previous versions of Docker this is a problem or not.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/190 **Author:** [@albertofem](https://github.com/albertofem) **Created:** 4/13/2020 **Status:** ✅ Merged **Merged:** 4/16/2020 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `feature/remove_length_constraint` --- ### 📝 Commits (1) - [`2988e7f`](https://github.com/nektos/act/commit/2988e7f9a59e08bc2c6cda89f9be666888079867) Remove length constraint ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/run_context.go` (+1 -1) </details> ### 📄 Description There is a 30 length hardcoded limit for containers name, which makes matrix builds with long job names unable to run due to conflicting container names (see https://github.com/nektos/act/issues/174) Apparently docker does not imposes a constraint in the length of the container name, as seen in the engine code: https://github.com/docker/engine/blob/master/daemon/names.go#L59 Tested with `Docker version 19.03.8, build afacb8b` Not sure if in previous versions of Docker this is a problem or not. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:50:56 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:13 +03:00

[PR #1380] [MERGED] build(deps): bump github.com/rhysd/actionlint from 1.6.20 to 1.6.21 #1916

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1380

No description provided.

Rows
Columns