[PR #155] [MERGED] Add support for runs-on array form (closes #146) #1372

New issue

Closed

opened 2026-03-01 21:50:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:50:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/155
Author: @aidansteele
Created: 3/14/2020
Status: ✅ Merged
Merged: 3/16/2020
Merged by: @cplee

Base: master ← Head: master

📝 Commits (3)

53dc9d7 Add support for runs-on array form (closes #146)
b8ba987 Fixed style issues
af4d0d0 Merge branch 'master' into master

📊 Changes

3 files changed (+60 additions, -14 deletions)

View changed files

📝 pkg/model/workflow.go (+23 -1)
📝 pkg/runner/run_context.go (+23 -13)
📝 pkg/runner/testdata/runs-on/push.yml (+14 -0)

📄 Description

Implemented as per discussion in #146. I guess the "interesting" thing here is the tests. It was easy enough to see that the parser no longer crashes on the array form. I wasn't able to think of a test for the "no matching labels" case - right now it just logs a message and skips over it silently. This was the existing behaviour, so I guess that's not a problem?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/155 **Author:** [@aidansteele](https://github.com/aidansteele) **Created:** 3/14/2020 **Status:** ✅ Merged **Merged:** 3/16/2020 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`53dc9d7`](https://github.com/nektos/act/commit/53dc9d79c89ea8f093a515966cc0590ad6be14a6) Add support for runs-on array form (closes #146) - [`b8ba987`](https://github.com/nektos/act/commit/b8ba9872c06a5acfe20bd4876c11f694d2db8605) Fixed style issues - [`af4d0d0`](https://github.com/nektos/act/commit/af4d0d05d2a3ef271f183bf6fcc43e724f29b725) Merge branch 'master' into master ### 📊 Changes **3 files changed** (+60 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `pkg/model/workflow.go` (+23 -1) 📝 `pkg/runner/run_context.go` (+23 -13) 📝 `pkg/runner/testdata/runs-on/push.yml` (+14 -0) </details> ### 📄 Description Implemented as per discussion in #146. I guess the "interesting" thing here is the tests. It was easy enough to see that the parser no longer crashes on the array form. I wasn't able to think of a test for the "no matching labels" case - right now it just logs a message and skips over it silently. This was the existing behaviour, so I guess that's not a problem? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:50:54 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:12 +03:00

[PR #1372] [MERGED] build(deps): bump github.com/opencontainers/selinux from 1.10.1 to 1.10.2 #1909

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1372

No description provided.

Rows
Columns