[PR #154] [MERGED] Add support for step.working-directory (closes #149) #1371

New issue

Closed

opened 2026-03-01 21:50:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:50:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/154
Author: @aidansteele
Created: 3/13/2020
Status: ✅ Merged
Merged: 3/14/2020
Merged by: @cplee

Base: master ← Head: master

📝 Commits (1)

db10929 Add support for step.working-directory (closes #149)

📊 Changes

4 files changed (+24 additions, -0 deletions)

View changed files

📝 pkg/runner/runner_test.go (+1 -0)
📝 pkg/runner/step_context.go (+7 -0)
➕ pkg/runner/testdata/workdir/canary (+0 -0)
➕ pkg/runner/testdata/workdir/push.yml (+16 -0)

📄 Description

Let me know if you're unhappy with this approach and I'd be happy to change it. The main alternative I could think of was threading it through to docker exec itself, but that would be a substantial change to:

github.com/nektos/act@25e1ad687d/pkg/runner/step_context.go (L42)

github.com/nektos/act@25e1ad687d/pkg/runner/step_context.go (L29)

github.com/nektos/act@25e1ad687d/pkg/runner/run_context.go (L143)

github.com/nektos/act@25e1ad687d/pkg/container/docker_run.go (L119)

github.com/nektos/act@25e1ad687d/pkg/container/docker_run.go (L254)

And of course all associated interfaces and structs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/154 **Author:** [@aidansteele](https://github.com/aidansteele) **Created:** 3/13/2020 **Status:** ✅ Merged **Merged:** 3/14/2020 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`db10929`](https://github.com/nektos/act/commit/db109292b743255b58a87c66fa40770a0a97f4af) Add support for step.working-directory (closes #149) ### 📊 Changes **4 files changed** (+24 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/runner_test.go` (+1 -0) 📝 `pkg/runner/step_context.go` (+7 -0) ➕ `pkg/runner/testdata/workdir/canary` (+0 -0) ➕ `pkg/runner/testdata/workdir/push.yml` (+16 -0) </details> ### 📄 Description Let me know if you're unhappy with this approach and I'd be happy to change it. The main alternative I could think of was threading it through to `docker exec` itself, but that would be a substantial change to: https://github.com/nektos/act/blob/25e1ad687d34102aa1508da38cef0e36a13a9b87/pkg/runner/step_context.go#L42 https://github.com/nektos/act/blob/25e1ad687d34102aa1508da38cef0e36a13a9b87/pkg/runner/step_context.go#L29 https://github.com/nektos/act/blob/25e1ad687d34102aa1508da38cef0e36a13a9b87/pkg/runner/run_context.go#L143 https://github.com/nektos/act/blob/25e1ad687d34102aa1508da38cef0e36a13a9b87/pkg/container/docker_run.go#L119 https://github.com/nektos/act/blob/25e1ad687d34102aa1508da38cef0e36a13a9b87/pkg/container/docker_run.go#L254 And of course all associated interfaces and structs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:50:54 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:12 +03:00

[PR #1371] [MERGED] build(deps): bump github.com/rhysd/actionlint from 1.6.19 to 1.6.20 #1908

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1371

No description provided.

Rows
Columns