[PR #118] [MERGED] fix #117 - handle whitespace in actrc secrets #1357

New issue

Closed

opened 2026-03-01 21:50:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:50:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/118
Author: @Steffen911
Created: 3/2/2020
Status: ✅ Merged
Merged: 3/2/2020
Merged by: @cplee

Base: master ← Head: fix/117-secrets

📝 Commits (3)

02d9ffd fix #117 - handle whitespace in actrc secrets
b4f741e Merge branch 'master' into fix/117-secrets
d655db3 Switch to raw string on regex pattern

📊 Changes

2 files changed (+3 additions, -2 deletions)

View changed files

📝 cmd/root.go (+2 -1)
📝 cmd/secrets.go (+1 -1)

📄 Description

Fixes #117

Currently whitespaces in secrets provided via .actrc lead to problems, because strings.Fields splits on all spaces. Now, only the first space is used for splitting. Same for = in the secret handling method.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/118 **Author:** [@Steffen911](https://github.com/Steffen911) **Created:** 3/2/2020 **Status:** ✅ Merged **Merged:** 3/2/2020 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `fix/117-secrets` --- ### 📝 Commits (3) - [`02d9ffd`](https://github.com/nektos/act/commit/02d9ffd5e397429833cdf941bd0856f386714e2a) fix #117 - handle whitespace in actrc secrets - [`b4f741e`](https://github.com/nektos/act/commit/b4f741e32b2a3838a554d842f30371551e8e49af) Merge branch 'master' into fix/117-secrets - [`d655db3`](https://github.com/nektos/act/commit/d655db3407837d50e871e9d92b3532eebaa3db06) Switch to raw string on regex pattern ### 📊 Changes **2 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `cmd/root.go` (+2 -1) 📝 `cmd/secrets.go` (+1 -1) </details> ### 📄 Description Fixes #117 Currently whitespaces in secrets provided via `.actrc` lead to problems, because `strings.Fields` splits on _all_ spaces. Now, only the first space is used for splitting. Same for `=` in the secret handling method. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:50:50 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:09 +03:00

[PR #1357] [MERGED] build(deps): bump actions/stale from 5 to 6 #1899

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1357

No description provided.

Rows
Columns