[PR #48] [MERGED] Ignore error, vet failure #1340

New issue

Closed

opened 2026-03-01 21:50:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:50:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/48
Author: @marccampbell
Created: 3/10/2019
Status: ✅ Merged
Merged: 3/10/2019
Merged by: @cplee

Base: master ← Head: ignore-response

📝 Commits (1)

45f8309 Ignore error, vet failure

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 container/docker_pull.go (+1 -1)

📄 Description

This doesn't change the functional behavior of act, but it resolves an error that was erroring when running vet.

Adding the _ = before this line will resolve the following error on make build:

container/docker_pull.go:37:26: Error return value of `input.logDockerResponse` is not checked (errcheck)
                input.logDockerResponse(reader, err != nil)
                                       ^
Error: exit with `FAILURE`: 1
exit status 1
make[2]: *** [check] Error 1
make[1]: *** [act] Error 2
make: *** [build] Error 2

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/48 **Author:** [@marccampbell](https://github.com/marccampbell) **Created:** 3/10/2019 **Status:** ✅ Merged **Merged:** 3/10/2019 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `ignore-response` --- ### 📝 Commits (1) - [`45f8309`](https://github.com/nektos/act/commit/45f8309524a1624d3712fb4ce08fd6500c02466e) Ignore error, vet failure ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `container/docker_pull.go` (+1 -1) </details> ### 📄 Description This doesn't change the functional behavior of act, but it resolves an error that was erroring when running vet. Adding the `_ =` before this line will resolve the following error on `make build`: ``` container/docker_pull.go:37:26: Error return value of `input.logDockerResponse` is not checked (errcheck) input.logDockerResponse(reader, err != nil) ^ Error: exit with `FAILURE`: 1 exit status 1 make[2]: *** [check] Error 1 make[1]: *** [act] Error 2 make: *** [build] Error 2 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:50:46 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:06 +03:00

[PR #1340] [MERGED] build(deps): bump github.com/docker/cli from 20.10.17+incompatible to 20.10.18+incompatible #1890

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1340

No description provided.

Rows
Columns