[PR #34] [MERGED] Regex tweaks #1331

New issue

Closed

opened 2026-03-01 21:50:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:50:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/34
Author: @sosedoff
Created: 2/14/2019
Status: ✅ Merged
Merged: 2/15/2019
Merged by: @cplee

Base: master ← Head: regex-fix

📝 Commits (2)

fb77d5a Regex tweaks
6addc48 Add extra test cases for testing git slugs

📊 Changes

2 files changed (+14 additions, -10 deletions)

View changed files

📝 common/git.go (+12 -10)
📝 common/git_test.go (+2 -0)

📄 Description

Made a few small changes to the git slug parsing:

Moved (and properly renamed) regular expressions into vars
Fixed failing test where github http regex was not matching http://github.com/user/repo without .git extension.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/34 **Author:** [@sosedoff](https://github.com/sosedoff) **Created:** 2/14/2019 **Status:** ✅ Merged **Merged:** 2/15/2019 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `regex-fix` --- ### 📝 Commits (2) - [`fb77d5a`](https://github.com/nektos/act/commit/fb77d5a88388cfc882cf3ad45a607b7d7b6931e9) Regex tweaks - [`6addc48`](https://github.com/nektos/act/commit/6addc48cde9a7ecf468d324b4c4f29d02ecf23c8) Add extra test cases for testing git slugs ### 📊 Changes **2 files changed** (+14 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `common/git.go` (+12 -10) 📝 `common/git_test.go` (+2 -0) </details> ### 📄 Description Made a few small changes to the git slug parsing: - Moved (and properly renamed) regular expressions into vars - Fixed failing test where github http regex was not matching `http://github.com/user/repo` without `.git` extension. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:50:43 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:05 +03:00

[PR #1331] [MERGED] fix: support expression for step's continue-on-error field (#900) #1886

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1331

No description provided.

Rows
Columns