mirror of
https://github.com/nektos/act.git
synced 2026-04-26 01:15:51 +03:00
[GH-ISSUE #5894] Machine's ip address recorded in generated man page #1277
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#1277
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jelly on GitHub (Aug 4, 2025).
Original GitHub issue: https://github.com/nektos/act/issues/5894
Bug report info
Command used with act
Describe issue
The generated man page includes the outbound ip address of the server which the act generated the man page of. This makes the package non-reproducible for Arch Linux as rebuilding the package on a different server will record a different IP Address making the package non-reproducible.
From a privacy perspective it also doesn't seem worth it to record the users IP Address in a man page, replacing it with an example ip address should resolve both issues.
Link to GitHub repository
No response
Workflow content
Relevant log output
Additional information
No response
@panekj commented on GitHub (Aug 6, 2025):
It's used as a default value for that option. Manpages are generated straight from the flags declaration. If you wish to not include that, you can patch the source:
github.com/nektos/act@bf8e52ba71/cmd/root.go (L118C2-L118C9)@ChristopherHX commented on GitHub (Aug 6, 2025):
I believe this is about the archlinux package repository using this command in a packaging script
IMHO knowing which ip is used by act in --help by default is helpful, man page generation was not by initiative.
Maybe redact them in the man page command?
@panekj commented on GitHub (Aug 6, 2025):
I was tryin to do it via
Set()but it seems it doesn't work that way.The above change works, but I thought we could maybe also change the type we use for those addresses from
StringVarPtoIPVarPso that way we get the IP address validation and could drop the regex.0001-fix-replace-address-flags-with-net.IP-and-redact-in-.patch
@ChristopherHX commented on GitHub (Aug 17, 2025):
The only thing I would like to avoid is a static initializer of GetOutboundIP()
In one of my projects someone didn't like that an udp socket is even created if passing explicit values...
Otherwise your patch looks good, we might even get ip format validation.
My activity in the nektos/act project is declining
@jelly commented on GitHub (Aug 18, 2025):
Yes, we run
"./$pkgname" --man-page >"$pkgname.1"which thus records the build machine's ip address. Building it on another host would change that address.@AbhinavSivanandhan commented on GitHub (Oct 10, 2025):
Hi, I've created a PR with the recommended fix: https://github.com/nektos/act/pull/5948
Please let me know if this resolves the issue as expected.
@AbhinavSivanandhan commented on GitHub (Oct 13, 2025):
Hi! When you have a moment, could you take a look at #5948?
What: redact IP-like defaults only for --man-page (no runtime change) — Fixes #5894.
Notes: tight scope (-addr|-address, IPv4/:port), placeholder [auto-detected IP]. Tests + manual check added.
I’m happy to switch the placeholder or adjust scope per your guidance. If this isn’t a priority, no worries, I’ll just close it. Thanks!
@jelly @panekj @ChristopherHX
@ChristopherHX commented on GitHub (Oct 13, 2025):
We cannot merge anything right now, this project is frozen only a single existing admin can repair this state. Requested explicitly a review in https://github.com/nektos/act/pull/5944.
Once this PR is merged or otherwise fixed, I would review your PR.
What follows is my own opinion on the state of nektos/act:
In long term I plan to leave this GitHub Organization and sunset my work here, because it is no longer maintainable
Moved my golang open source work to the Gitea Project, which has a more active and friendly community
@AbhinavSivanandhan commented on GitHub (Oct 13, 2025):
Thank you so much for letting me know Christopher! This saved me a lot of time.