mirror of
https://github.com/nektos/act.git
synced 2026-04-26 01:15:51 +03:00
[GH-ISSUE #2707] Passing " " (a space) as a SECRET causes " " in output to be masked #1223
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#1223
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jklap on GitHub (Mar 24, 2025).
Original GitHub issue: https://github.com/nektos/act/issues/2707
Bug report info
Command used with act
Describe issue
If you pass in a SECRET value with just a single space (ie " ") then all single spaces in the output are masked:
While masking secrets is obviously important, there a valid scenarios where passing a single space can be valid so maybe we need a rule in the masking logic to ignore this scenario?
Link to GitHub repository
No response
Workflow content
Relevant log output
Additional information
No response
@Mrityunjay20 commented on GitHub (May 23, 2025):
Hi @jklap,
If your workflow logic really needs " " as a secret, set a dummy placeholder instead, and transform it within your workflow:
export AWS_ROLE_ARN="<SPACE>"Then inside your workflow:
AWS_ROLE_ARN: ${{ secrets.AWS_ROLE_ARN == '<SPACE>' && ' ' || secrets.AWS_ROLE_ARN }}I think this should work
@jklap commented on GitHub (May 27, 2025):
Thanks, but we do not want to make changes to a workflow with logic specific to
actvs logic specific to GitHub itself. Completely eliminates the value of runningactlocally to test workflows as you aren't testing the same code that would run on GitHub