[GH-ISSUE #2621] pull-request-activity-type lacks some possible values values #1192

New issue

Open

opened 2026-03-01 21:49:34 +03:00 by kerem · 1 comment

kerem commented

2026-03-01 21:49:34 +03:00

Owner

Originally created by @vittorfp on GitHub (Jan 16, 2025).
Original GitHub issue: https://github.com/nektos/act/issues/2621

The list of valid pull-request-activity-type strings is not complete, for example milestoned is not a valid action, as stated in GHA docs: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request

Snippet to reproduce:

name: final-review
on:
  pull_request:
    types: [milestoned]


...

Output of act:

Line: 5 Column 12: Failed to match pull-request-activity-types: Line: 5 Column 13: Expected one of assigned,unassigned,labeled,unlabeled,opened,edited,closed,reopened,synchronize,converted_to_draft,ready_for_review,locked,unlocked,review_requested,review_request_removed,auto_merge_enabled,auto_merge_disabled got milestoned

Probably adding the full list of values here would solve.

Originally created by @vittorfp on GitHub (Jan 16, 2025). Original GitHub issue: https://github.com/nektos/act/issues/2621 The list of valid `pull-request-activity-type` strings is not complete, for example `milestoned` is not a valid action, as stated in GHA docs: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request Snippet to reproduce: ``` name: final-review on: pull_request: types: [milestoned] ... ``` Output of act: ``` Line: 5 Column 12: Failed to match pull-request-activity-types: Line: 5 Column 13: Expected one of assigned,unassigned,labeled,unlabeled,opened,edited,closed,reopened,synchronize,converted_to_draft,ready_for_review,locked,unlocked,review_requested,review_request_removed,auto_merge_enabled,auto_merge_disabled got milestoned ``` Probably adding the full list of values [here](https://github.com/nektos/act/blob/a9e31cde304fb989e59068c6b1cb2f04a5fa5931/pkg/schema/workflow_schema.json#L691) would solve.

kerem commented

2026-03-01 21:49:35 +03:00

Author

Owner

@ChristopherHX commented on GitHub (Jan 18, 2025):

Maybe report it to GitHub as well https://github.com/actions/languageservices/blob/main/workflow-parser/src/workflow-v1.0.json ?

I copied that file into act, yes we could alter our copy as well

Open a PR? I only can give +1 review, but you need +2 reviews for a merge

In any case this change from my side would disable the strict check to be not stricter than the GitHub Actions Backend.

However not getting any attention, for required reviews

@ChristopherHX commented on GitHub (Jan 18, 2025): Maybe report it to GitHub as well https://github.com/actions/languageservices/blob/main/workflow-parser/src/workflow-v1.0.json ? I copied that file into act, yes we could alter our copy as well Open a PR? _I only can give +1 review, but you need +2 reviews for a merge_ In any case [this change from my side](https://github.com/nektos/act/pull/2524) would disable the strict check to be not stricter than the GitHub Actions Backend. However not getting any attention, for required reviews