mirror of
https://github.com/nektos/act.git
synced 2026-04-26 01:15:51 +03:00
[GH-ISSUE #2444] act 0.2.66 Error: workflow is not valid. 'spelling.yml': Line: 112 Column 5: Failed to match job-factory: Line: 119 Column 9: Unknown Function Call success #1125
Labels
No labels
area/action
area/cli
area/docs
area/image
area/runner
area/workflow
backlog
confirmed/not-planned
kind/bug
kind/discussion
kind/external
kind/feature-request
kind/question
meta/duplicate
meta/invalid
meta/need-more-info
meta/resolved
meta/wontfix
meta/workaround
needs-work
pull-request
review/not-planned
size/M
size/XL
size/XXL
stale
stale-exempt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/act#1125
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jsoref on GitHub (Sep 9, 2024).
Original GitHub issue: https://github.com/nektos/act/issues/2444
Originally assigned to: @ChristopherHX on GitHub.
Bug report info
Command used with act
Describe issue
Historically, I'd get this output:
Link to GitHub repository
github.com/check-spelling/spell-check-this@0a3288fa36Workflow content
Relevant log output
Additional information
No response
@ChristopherHX commented on GitHub (Sep 9, 2024):
Tbh. I expected such issues to land before the 9th September.
I wonder if this is accepted, when you use
${{ success() }}via explicit expressions.Seems like a lack of CI test material for this case
I will look into this tomorrow.
@jsoref commented on GitHub (Sep 9, 2024):
I have my own self-build of
actin my path and thus thebrewauto update didn't give me the failure ...@jsoref commented on GitHub (Sep 9, 2024):
I'd encourage you to just add spell-check-this to the CI test material 😉.
@jsoref commented on GitHub (Sep 9, 2024):
Note, the error reporting is lousy.
Here's line 112:
github.com/check-spelling/spell-check-this@0a3288fa36/.github/workflows/spelling.yml (L112)@jsoref commented on GitHub (Sep 9, 2024):
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsif
@jsoref commented on GitHub (Sep 9, 2024):
Wrapping
${{ ... }}doesn't help. The only thing I can do is to remove thesuccess()andfailure()bits@ChristopherHX commented on GitHub (Sep 10, 2024):
Yes I know, the goal was error reporting not pretty error reporting.
I thoughtback then that I fixed the parsing problem for special functions.
However it could be that I only fixed hashfiles
github.com/nektos/act@d8b6f618d9/pkg/schema/workflow_schema.json (L1514)My validation code might be just unable to parse the success(0,MAX) and excludes those functions.
hashfiles is defined as (0,255)
@ChristopherHX commented on GitHub (Sep 10, 2024):
Hmm job step if is ok, because it also uses 255 not MAX, seems like I didn't inspect the whole schema file from GitHub Employees for additional aliases.
I used scan with integer placeholder
@brianjmurrell commented on GitHub (Sep 10, 2024):
What's the (end-user) solution here? Roll back to v0.2.65?
@ChristopherHX commented on GitHub (Sep 10, 2024):
Yes, but know this isn't easy for some package managers.
@ChristopherHX commented on GitHub (Sep 10, 2024):
I created a fix now.
@ChristopherHX commented on GitHub (Sep 10, 2024):
Created https://github.com/nektos/act/releases/tag/v0.2.67
Please tell me if you find other validation issues
@jsoref commented on GitHub (Sep 10, 2024):
Well, I've set up a cron job to try running act daily against spell-check-this and check-spelling:
https://github.com/check-spelling-sandbox/act-use-spell-check-this/actions/runs/10801275723/job/29961096172
I haven't hit validation issues, but I've hit:
github.com/jsoref/check-spelling@7f33470374/unknown-words.sh (L1951-L1956)I don't see anything else that's obviously broken at this time, although that pair is frustrating in that it makes it hard to validate other things.
@ChristopherHX commented on GitHub (Sep 11, 2024):
My resources for investing time into nektos/act are exhausted, my internship semester throttled the time I invest into open source.
@amyb-asu commented on GitHub (Sep 12, 2024):
Hi I'm getting a different
workflow is not validfor my workflow. It was working on 0.2.65 but it is not working on 0.2.66 or 0.2.67I'm assuming it is a similar issue as it was introduced at the same time. However the fix #2446 does not fix my issue and my runs are still failing.
Here is the start of my action, where it fails to parse the
workflow_dispatch@jsoref commented on GitHub (Sep 12, 2024):
@amyb-asu: please open a new ticket.