[PR #374] fix(dns): return NODATA instead of NXDOMAIN when a name exists with a… #396

New issue

Open

opened 2026-03-13 16:21:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:21:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/374
Author: @lbauer13
Created: 2/19/2025
Status: 🔄 Open

Base: master ← Head: fix/nxdomain

📝 Commits (2)

d692267 fix(dns): return NODATA instead of NXDOMAIN when a name exists with another type
27a8770 test: dns rcodes for authoritative names with and without answer

📊 Changes

2 files changed (+61 additions, -11 deletions)

View changed files

📝 dns.go (+22 -8)
📝 dns_test.go (+39 -3)

📄 Description

Return NODATA instead of NXDOMAIN when a name exists with another type

Should fix https://github.com/joohoi/acme-dns/issues/373

When a TXT exists for a given name but a resolver queries another type, acme-dns will now return NODATA to prevent the resolver from caching a negative response for further TXT queries.

It still returns NXDOMAIN if the name does not exist at all.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/374 **Author:** [@lbauer13](https://github.com/lbauer13) **Created:** 2/19/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix/nxdomain` --- ### 📝 Commits (2) - [`d692267`](https://github.com/acme-dns/acme-dns/commit/d69226707e5694e0307672a69f88909ab1bc8a5a) fix(dns): return NODATA instead of NXDOMAIN when a name exists with another type - [`27a8770`](https://github.com/acme-dns/acme-dns/commit/27a8770ef13aa46b0415294dc9140e872875701e) test: dns rcodes for authoritative names with and without answer ### 📊 Changes **2 files changed** (+61 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `dns.go` (+22 -8) 📝 `dns_test.go` (+39 -3) </details> ### 📄 Description Return NODATA instead of NXDOMAIN when a name exists with another type Should fix https://github.com/joohoi/acme-dns/issues/373 When a TXT exists for a given name but a resolver queries another type, acme-dns will now return NODATA to prevent the resolver from caching a negative response for further TXT queries. It still returns NXDOMAIN if the name does not exist at all. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>