[PR #378] get endpoint idea #392

New issue

Open

opened 2026-03-13 16:21:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:21:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/378
Author: @jvanasco
Created: 3/11/2025
Status: 🔄 Open

Base: master ← Head: feature-check

📝 Commits (3)

5263dce get endpoint idea
578b503 fixed typo
8594bf4 added get to readme; refactored

📊 Changes

4 files changed (+59 additions, -0 deletions)

View changed files

📝 README.md (+16 -0)
📝 api.go (+28 -0)
📝 api_test.go (+14 -0)
📝 main.go (+1 -0)

📄 Description

fixes #377

adds /get endpoint, which requires the same params as /update BUT does not write the txt value and returns the existing txt value

Originally: I would rather have not required a subdomain for POST, but this leverages the existing auth AND works as a decent dry-run . someone more familiar with Go could write a much better PR. this is just a proof of concept.

Now: Requiring the subdomain makes sense, and I refactored the code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/378 **Author:** [@jvanasco](https://github.com/jvanasco) **Created:** 3/11/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `feature-check` --- ### 📝 Commits (3) - [`5263dce`](https://github.com/acme-dns/acme-dns/commit/5263dce9198f6cee1737b587680d180a256c9819) get endpoint idea - [`578b503`](https://github.com/acme-dns/acme-dns/commit/578b5039417055c491a82e771d6968a7cc7b6879) fixed typo - [`8594bf4`](https://github.com/acme-dns/acme-dns/commit/8594bf47c06f422cce372867ee5c47b4eb4fdeb3) added `get` to readme; refactored ### 📊 Changes **4 files changed** (+59 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+16 -0) 📝 `api.go` (+28 -0) 📝 `api_test.go` (+14 -0) 📝 `main.go` (+1 -0) </details> ### 📄 Description fixes #377 adds `/get` endpoint, which requires the same params as `/update` BUT does not write the txt value and returns the existing txt value Originally: I would rather have not required a subdomain for POST, but this leverages the existing auth AND works as a decent dry-run . someone more familiar with Go could write a much better PR. this is just a proof of concept. Now: Requiring the subdomain makes sense, and I refactored the code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>