337 #389

New issue

Open

opened 2026-03-13 16:21:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:21:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/351
Author: @maddes-b
Created: 4/11/2024
Status: 🔄 Open

Base: master ← Head: fix/certmagic-usage

📝 Commits (1)

f6a24a6 Fix certmagic usage. Fixes https://github.com/joohoi/acme-dns/issues/337

📊 Changes

3 files changed (+98 additions, -19 deletions)

View changed files

📝 go.mod (+10 -9)
📝 go.sum (+85 -0)
📝 main.go (+3 -10)

📄 Description

No separate certmagic cache needed. Default config and cache are sufficient to handle the certificates for the HTTP API.
Updated to certmagic v0.20.

Issue of double cache was introduced by github.com/joohoi/acme-dns@27e8251d11 (from https://github.com/joohoi/acme-dns/pull/334), when updating certmagic to v0.17, and reported in https://github.com/joohoi/acme-dns/issues/337
Also maybe related to https://github.com/joohoi/acme-dns/issues/347, no cert, no update, no txt record.

Succesfully Tested (Ubuntu 22.04 LTS):

normal renewal
revoked cert renewal

Built on Ubuntu 22.04 LTS: GOPATH=/tmp/go-acme-dns CGO_ENABLED=1 go build (CGO_ENABLED for sqlite)

Installation on Ubuntu 22.04 LTS:

install -v -t /usr/local/bin/ acme-dns
install -v -d /etc/acme-dns/
install -v -t /etc/acme-dns/ config.cfg

adduser --system --gecos "acme-dns Service" --disabled-password --group --home /var/lib/acme-dns acme-dns
install -v -m u=rw-s,go=r-s -t /etc/systemd/system/ acme-dns.service
systemctl daemon-reload

systemctl enable acme-dns.service
systemctl start acme-dns.service

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/351 **Author:** [@maddes-b](https://github.com/maddes-b) **Created:** 4/11/2024 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix/certmagic-usage` --- ### 📝 Commits (1) - [`f6a24a6`](https://github.com/acme-dns/acme-dns/commit/f6a24a60f9248f259002be661bf41c03da3d8107) Fix certmagic usage. Fixes https://github.com/joohoi/acme-dns/issues/337 ### 📊 Changes **3 files changed** (+98 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `go.mod` (+10 -9) 📝 `go.sum` (+85 -0) 📝 `main.go` (+3 -10) </details> ### 📄 Description No separate certmagic cache needed. Default config and cache are sufficient to handle the certificates for the HTTP API. Updated to certmagic v0.20. Issue of double cache was introduced by https://github.com/joohoi/acme-dns/commit/27e8251d11ba0a08c9b576fc04d61c1c7ba9b500 (from https://github.com/joohoi/acme-dns/pull/334), when updating certmagic to v0.17, and reported in https://github.com/joohoi/acme-dns/issues/337 Also maybe related to https://github.com/joohoi/acme-dns/issues/347, no cert, no update, no txt record. Succesfully Tested (Ubuntu 22.04 LTS): - normal renewal - revoked cert renewal Built on Ubuntu 22.04 LTS: `GOPATH=/tmp/go-acme-dns CGO_ENABLED=1 go build` (CGO_ENABLED for sqlite) Installation on Ubuntu 22.04 LTS: ``` install -v -t /usr/local/bin/ acme-dns install -v -d /etc/acme-dns/ install -v -t /etc/acme-dns/ config.cfg adduser --system --gecos "acme-dns Service" --disabled-password --group --home /var/lib/acme-dns acme-dns install -v -m u=rw-s,go=r-s -t /etc/systemd/system/ acme-dns.service systemctl daemon-reload systemctl enable acme-dns.service systemctl start acme-dns.service ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>