[PR #340] [CLOSED] Refactor & automatically build Docker image #385

New issue

Closed

opened 2026-03-13 16:20:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:20:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/340
Author: @minus7
Created: 5/27/2023
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (2)

5da7960 Refactor Dockerfile
0e9f8ba Automatically build and deploy Docker image

📊 Changes

4 files changed (+114 additions, -20 deletions)

View changed files

➕ .github/workflows/docker-publish.yml (+92 -0)
📝 Dockerfile (+14 -12)
📝 README.md (+4 -4)
📝 docker-compose.yml (+4 -4)

📄 Description

Refactor Dockerfile
- Use code from context instead of cloning the repo
- Download dependencies first for caching
- Run as unprivileged account (note that this break running on ports
  <1024 on Docker <20.03; default ports changed accordingly)
I'm not actually sure the ca-certificates package is required in the image, requesting certificates seems to work without it, though I did not test fully obtaining one.
Automatically build and deploy Docker image via GitHub Actions
- I mainly did this so I can use it right away. Dunno if it makes sense, especially since images are on Docker Hub already.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/340 **Author:** [@minus7](https://github.com/minus7) **Created:** 5/27/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`5da7960`](https://github.com/acme-dns/acme-dns/commit/5da79601d59565fcdd65a067ab7c39d8b214f7c6) Refactor Dockerfile - [`0e9f8ba`](https://github.com/acme-dns/acme-dns/commit/0e9f8bafb7ecf6e663d5daad56dce01dbcfa7ed7) Automatically build and deploy Docker image ### 📊 Changes **4 files changed** (+114 additions, -20 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/docker-publish.yml` (+92 -0) 📝 `Dockerfile` (+14 -12) 📝 `README.md` (+4 -4) 📝 `docker-compose.yml` (+4 -4) </details> ### 📄 Description - Refactor Dockerfile - Use code from context instead of cloning the repo - Download dependencies first for caching - Run as unprivileged account (note that this break running on ports <1024 on Docker <20.03; default ports changed accordingly) - I'm not actually sure the ca-certificates package is required in the image, requesting certificates seems to work without it, though I did not test fully obtaining one. - Automatically build and deploy Docker image via GitHub Actions - I mainly did this so I can use it right away. Dunno if it makes sense, especially since images are on Docker Hub already. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>