[PR #270] Allow set-and-delete flow that is usually used by acme-clients #366

Open
opened 2026-03-13 16:19:51 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/270
Author: @Yannik
Created: 7/16/2021
Status: 🔄 Open

Base: masterHead: set-delete-flow


📝 Commits (3)

  • 91599ac Support deleting txt records
  • 5a16ea9 Allow set-and-delete flow that is usually used by acme-clients
  • 7e121f0 Fix linter issues

📊 Changes

7 files changed (+546 additions, -121 deletions)

View changed files

📝 README.md (+32 -1)
📝 api.go (+36 -0)
📝 api_test.go (+242 -1)
📝 db.go (+85 -72)
📝 dns_test.go (+149 -47)
📝 main.go (+1 -0)
📝 types.go (+1 -0)

📄 Description

This PR builds on the work of @jacobmyers-codeninja's PR #245 and fully implements set-and-delete flow.

This fixes issues such as https://github.com/dehydrated-io/dehydrated/issues/832


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/270 **Author:** [@Yannik](https://github.com/Yannik) **Created:** 7/16/2021 **Status:** 🔄 Open **Base:** `master` ← **Head:** `set-delete-flow` --- ### 📝 Commits (3) - [`91599ac`](https://github.com/acme-dns/acme-dns/commit/91599ac4fc5c88a2899ab76869c6b0df8d8234f7) Support deleting txt records - [`5a16ea9`](https://github.com/acme-dns/acme-dns/commit/5a16ea93e9bdd936358785a969bcb880e6c69537) Allow set-and-delete flow that is usually used by acme-clients - [`7e121f0`](https://github.com/acme-dns/acme-dns/commit/7e121f0f3cb215d89991e6f291928b8033ded24e) Fix linter issues ### 📊 Changes **7 files changed** (+546 additions, -121 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+32 -1) 📝 `api.go` (+36 -0) 📝 `api_test.go` (+242 -1) 📝 `db.go` (+85 -72) 📝 `dns_test.go` (+149 -47) 📝 `main.go` (+1 -0) 📝 `types.go` (+1 -0) </details> ### 📄 Description This PR builds on the work of @jacobmyers-codeninja's PR #245 and fully implements set-and-delete flow. This fixes issues such as https://github.com/dehydrated-io/dehydrated/issues/832 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/acme-dns#366
No description provided.