[PR #264] Fix invalid nxdomain response (fixes #257) #357

New issue

Open

opened 2026-03-13 16:19:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:19:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/264
Author: @Yannik
Created: 6/9/2021
Status: 🔄 Open

Base: master ← Head: fix-invalid-nxdomain-response

📝 Commits (2)

6d6fe51 Return NODATA instead of NXDOMAIN if we have RR of other type for domain
b1ed162 SOA belongs in authority section in case of NODATA response

📊 Changes

1 file changed (+14 additions, -2 deletions)

View changed files

📝 dns.go (+14 -2)

📄 Description

This fixes #257

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/264 **Author:** [@Yannik](https://github.com/Yannik) **Created:** 6/9/2021 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix-invalid-nxdomain-response` --- ### 📝 Commits (2) - [`6d6fe51`](https://github.com/acme-dns/acme-dns/commit/6d6fe51d921943a4590b4eb0e02be969eede7825) Return NODATA instead of NXDOMAIN if we have RR of other type for domain - [`b1ed162`](https://github.com/acme-dns/acme-dns/commit/b1ed1624947293e08b4e8db248c76c878ff799f3) SOA belongs in authority section in case of NODATA response ### 📊 Changes **1 file changed** (+14 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `dns.go` (+14 -2) </details> ### 📄 Description This fixes #257 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>