[PR #190] [MERGED] Migrate over to certmagic from using autocert #339

New issue

Closed

opened 2026-03-13 16:18:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:18:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/190
Author: @joohoi
Created: 10/20/2019
Status: ✅ Merged
Merged: 10/20/2019
Merged by: @joohoi

Base: master ← Head: certmagic

📝 Commits (9)

6f921ed Use certmagic for challenge validation
a2f4f1a Merge remote-tracking branch 'origin/master' into certmagic
e19d5a5 WIP
2d473e5 Get the correct key
afed867 Merge remote-tracking branch 'origin/master' into certmagic
aacf9dc Override preflight check logic
976afe5 Fix logging for imported packages and tidy config.cfg
b6b306d Fix test and add docstrings
ddc219b Update README

📊 Changes

8 files changed (+465 additions, -44 deletions)

View changed files

📝 README.md (+13 -11)
➕ challengeprovider.go (+30 -0)
📝 config.cfg (+3 -7)
📝 dns.go (+48 -7)
📝 go.mod (+8 -3)
📝 go.sum (+295 -0)
📝 main.go (+67 -15)
📝 main_test.go (+1 -1)

📄 Description

This PR replaces the autocert package that was used for the HTTP api certificate handling with certmagic.

In addition to this, it changes the HTTP api certificate validation over to DNS challenge, which a acme-dns instance should always be able to fulfill, if it's not misconfigured in a way that would make it incapable of handling the issuance for its clients as well.

In broader sense, this means that acme-dns is finally able to acquire and configure HTTPS correctly regardless of being deployed without publicly accessible HTTP API.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/190 **Author:** [@joohoi](https://github.com/joohoi) **Created:** 10/20/2019 **Status:** ✅ Merged **Merged:** 10/20/2019 **Merged by:** [@joohoi](https://github.com/joohoi) **Base:** `master` ← **Head:** `certmagic` --- ### 📝 Commits (9) - [`6f921ed`](https://github.com/acme-dns/acme-dns/commit/6f921eda5060c6ebd2e1fe96fa3db66a845d808d) Use certmagic for challenge validation - [`a2f4f1a`](https://github.com/acme-dns/acme-dns/commit/a2f4f1adb23e99f32ae8ded301744e88b486225e) Merge remote-tracking branch 'origin/master' into certmagic - [`e19d5a5`](https://github.com/acme-dns/acme-dns/commit/e19d5a5aefa6315eeb104e7a0b19fda2f1dc77c1) WIP - [`2d473e5`](https://github.com/acme-dns/acme-dns/commit/2d473e5f322fc67396ec43d79ae2dedc0b3439a7) Get the correct key - [`afed867`](https://github.com/acme-dns/acme-dns/commit/afed8675cab4e28dbbec2fd2bbfff521e1fc1d82) Merge remote-tracking branch 'origin/master' into certmagic - [`aacf9dc`](https://github.com/acme-dns/acme-dns/commit/aacf9dc962635d14c814d2c1607b674d490b8e1d) Override preflight check logic - [`976afe5`](https://github.com/acme-dns/acme-dns/commit/976afe50142560f6980cf0d4140c5ca68a63bd5e) Fix logging for imported packages and tidy config.cfg - [`b6b306d`](https://github.com/acme-dns/acme-dns/commit/b6b306d5f19f53db7175cce0b3f8f9a50e5286e8) Fix test and add docstrings - [`ddc219b`](https://github.com/acme-dns/acme-dns/commit/ddc219b2f502e42f14c0fecc5dac6ef0c1f49f54) Update README ### 📊 Changes **8 files changed** (+465 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+13 -11) ➕ `challengeprovider.go` (+30 -0) 📝 `config.cfg` (+3 -7) 📝 `dns.go` (+48 -7) 📝 `go.mod` (+8 -3) 📝 `go.sum` (+295 -0) 📝 `main.go` (+67 -15) 📝 `main_test.go` (+1 -1) </details> ### 📄 Description This PR replaces the [autocert](https://godoc.org/golang.org/x/crypto/acme/autocert) package that was used for the HTTP api certificate handling with [certmagic](https://github.com/mholt/certmagic). In addition to this, it changes the HTTP api certificate validation over to DNS challenge, which a acme-dns instance should always be able to fulfill, if it's not misconfigured in a way that would make it incapable of handling the issuance for its clients as well. In broader sense, this means that acme-dns is finally able to acquire and configure HTTPS correctly regardless of being deployed without publicly accessible HTTP API. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>