[PR #162] [MERGED] Refactor: Use more specific type in argument of DB.Update #334

New issue

Closed

opened 2026-03-13 16:18:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:18:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/162
Author: @znerol
Created: 4/9/2019
Status: ✅ Merged
Merged: 6/12/2019
Merged by: @joohoi

Base: master ← Head: refactor/master/more-specific-param-type

📝 Commits (1)

ed32c53 Refactor: Use more specific type in argument of DB.Update

📊 Changes

5 files changed (+8 additions, -8 deletions)

View changed files

📝 api.go (+1 -1)
📝 db.go (+1 -1)
📝 db_test.go (+4 -4)
📝 dns_test.go (+1 -1)
📝 types.go (+1 -1)

📄 Description

The DB.Update function takes a type of ACMETxt. However, the function
only requires the Value and Subdomain fields.

Refactor the function such that it takes ACMETxtPost instead of the full
ACMETxt record. This will simplify extraction of txt-record related
logic from the db code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/162 **Author:** [@znerol](https://github.com/znerol) **Created:** 4/9/2019 **Status:** ✅ Merged **Merged:** 6/12/2019 **Merged by:** [@joohoi](https://github.com/joohoi) **Base:** `master` ← **Head:** `refactor/master/more-specific-param-type` --- ### 📝 Commits (1) - [`ed32c53`](https://github.com/acme-dns/acme-dns/commit/ed32c53f877c12faca20ef874b7476a1e240de2c) Refactor: Use more specific type in argument of DB.Update ### 📊 Changes **5 files changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `api.go` (+1 -1) 📝 `db.go` (+1 -1) 📝 `db_test.go` (+4 -4) 📝 `dns_test.go` (+1 -1) 📝 `types.go` (+1 -1) </details> ### 📄 Description The DB.Update function takes a type of ACMETxt. However, the function only requires the Value and Subdomain fields. Refactor the function such that it takes ACMETxtPost instead of the full ACMETxt record. This will simplify extraction of txt-record related logic from the db code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>