[PR #169] [MERGED] README: Add warning/advice about HTTPS API. #333

New issue

Closed

opened 2026-03-13 16:18:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:18:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/169
Author: @cpu
Created: 5/30/2019
Status: ✅ Merged
Merged: 6/12/2019
Merged by: @joohoi

Base: master ← Head: cpu-readme-https-warning

📝 Commits (2)

b271f5e README: Add warning/advice about HTTPS API.
02ac5f5 Merge branch 'master' into cpu-readme-https-warning

📊 Changes

1 file changed (+19 additions, -0 deletions)

View changed files

📝 README.md (+19 -0)

📄 Description

This PR updates the README to add a brief description of the tls configuration options. In particular using tls = "letsencrypt" is recommended and a warning is added about using tls = "cert" and allowing the certificate to expire.

For more background see:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/169 **Author:** [@cpu](https://github.com/cpu) **Created:** 5/30/2019 **Status:** ✅ Merged **Merged:** 6/12/2019 **Merged by:** [@joohoi](https://github.com/joohoi) **Base:** `master` ← **Head:** `cpu-readme-https-warning` --- ### 📝 Commits (2) - [`b271f5e`](https://github.com/acme-dns/acme-dns/commit/b271f5e97950409bcc71fef7e0a7236040344b9c) README: Add warning/advice about HTTPS API. - [`02ac5f5`](https://github.com/acme-dns/acme-dns/commit/02ac5f516a867e69bcd86b4e52eb3b9d89ecc088) Merge branch 'master' into cpu-readme-https-warning ### 📊 Changes **1 file changed** (+19 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+19 -0) </details> ### 📄 Description This PR updates the README to add a brief description of the `tls` configuration options. In particular using `tls = "letsencrypt"` is recommended and a warning is added about using `tls = "cert"` and allowing the certificate to expire. For more background see: * https://github.com/cpu/goacmedns/issues/5 * https://github.com/go-acme/lego/issues/900 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>