[PR #152] [MERGED] Respond case insensitively to A and SOA requests #329

New issue

Closed

opened 2026-03-13 16:17:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:17:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/152
Author: @cure
Created: 2/6/2019
Status: ✅ Merged
Merged: 2/7/2019
Merged by: @joohoi

Base: master ← Head: respond-case-insensitively

📝 Commits (2)

aa44cc4 When appending the SOA for authoritative NXDOMAIN responses, it needs to go in
145dcee Respond case-insensitively to A and SOA requests. Add corresponding tests.

📊 Changes

2 files changed (+32 additions, -8 deletions)

View changed files

📝 dns.go (+4 -4)
📝 dns_test.go (+28 -4)

📄 Description

Respond case-insensitively to A and SOA requests. Add corresponding tests.

This fixes the autocert feature with Let's Encrypt, because Let's Encrypt does a lookup for the A record with a deliberately mangled case.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/152 **Author:** [@cure](https://github.com/cure) **Created:** 2/6/2019 **Status:** ✅ Merged **Merged:** 2/7/2019 **Merged by:** [@joohoi](https://github.com/joohoi) **Base:** `master` ← **Head:** `respond-case-insensitively` --- ### 📝 Commits (2) - [`aa44cc4`](https://github.com/acme-dns/acme-dns/commit/aa44cc4481b5c768060e8eb405def4b588ca32f3) When appending the SOA for authoritative NXDOMAIN responses, it needs to go in - [`145dcee`](https://github.com/acme-dns/acme-dns/commit/145dcee4a68a42cb90a72f110d43f4a23c9b6a75) Respond case-insensitively to A and SOA requests. Add corresponding tests. ### 📊 Changes **2 files changed** (+32 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `dns.go` (+4 -4) 📝 `dns_test.go` (+28 -4) </details> ### 📄 Description Respond case-insensitively to A and SOA requests. Add corresponding tests. This fixes the autocert feature with Let's Encrypt, because Let's Encrypt does a lookup for the A record with a deliberately mangled case. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>