[PR #155] auth: using headers is optional #328

New issue

Open

opened 2026-03-13 16:17:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:17:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/155
Author: @tcely
Created: 3/3/2019
Status: 🔄 Open

Base: master ← Head: patch-1

📝 Commits (10+)

609c9a1 add getValidSubdomain function
05e8d6a add GetBySubdomain function
67dc8a2 auth: using headers is optional
8dcc8dc api_test: change expected result
2739213 add additional tests
33c5c58 use getValidSubdomain for validSubdomain
443fbb1 update docs for /update inputs
43de7ba Output fulldomain with txt value
d2bc627 Marshal /update response too
dcee58f adjust positive and negative TTL values

📊 Changes

10 files changed (+358 additions, -44 deletions)

View changed files

📝 README.md (+4 -3)
📝 api.go (+13 -1)
📝 api_test.go (+186 -1)
📝 auth.go (+47 -34)
📝 db.go (+43 -0)
📝 db_test.go (+27 -1)
📝 dns.go (+2 -2)
📝 types.go (+1 -0)
📝 validation.go (+9 -1)
📝 validation_test.go (+26 -1)

📄 Description

The POST data now contains:

txt
subdomain
password

This still checks X-Api-Key and X-Api-User for backwards compatibility. If a user is provided we'll still check it, but it is now optional.

This should address most of https://github.com/joohoi/acme-dns/issues/77 too.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/155 **Author:** [@tcely](https://github.com/tcely) **Created:** 3/3/2019 **Status:** 🔄 Open **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (10+) - [`609c9a1`](https://github.com/acme-dns/acme-dns/commit/609c9a15c3947c5f8e5bea7052f8d665c6a93da8) add getValidSubdomain function - [`05e8d6a`](https://github.com/acme-dns/acme-dns/commit/05e8d6ab29f094528e53fa1c65f53e23d9ceddd8) add GetBySubdomain function - [`67dc8a2`](https://github.com/acme-dns/acme-dns/commit/67dc8a2cc35813d58d02df89b24d0a7d4031d017) auth: using headers is optional - [`8dcc8dc`](https://github.com/acme-dns/acme-dns/commit/8dcc8dcd6d1a1f118002a01447dc35ad5c216e48) api_test: change expected result - [`2739213`](https://github.com/acme-dns/acme-dns/commit/27392139eccb63da39429633cbd6461eb26919bf) add additional tests - [`33c5c58`](https://github.com/acme-dns/acme-dns/commit/33c5c587e32ccedd1e9de9641ae39704590061ea) use getValidSubdomain for validSubdomain - [`443fbb1`](https://github.com/acme-dns/acme-dns/commit/443fbb192a70a25cad644412ead7d31e2d716a4d) update docs for /update inputs - [`43de7ba`](https://github.com/acme-dns/acme-dns/commit/43de7ba39cb555387d2e67008bc1c463e487a28c) Output fulldomain with txt value - [`d2bc627`](https://github.com/acme-dns/acme-dns/commit/d2bc627429446fb6c2479fa0cfc097d4939f7b65) Marshal /update response too - [`dcee58f`](https://github.com/acme-dns/acme-dns/commit/dcee58fdd3b0792ceaa568d18a3806cb516a7d3e) adjust positive and negative TTL values ### 📊 Changes **10 files changed** (+358 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+4 -3) 📝 `api.go` (+13 -1) 📝 `api_test.go` (+186 -1) 📝 `auth.go` (+47 -34) 📝 `db.go` (+43 -0) 📝 `db_test.go` (+27 -1) 📝 `dns.go` (+2 -2) 📝 `types.go` (+1 -0) 📝 `validation.go` (+9 -1) 📝 `validation_test.go` (+26 -1) </details> ### 📄 Description The POST data now contains: - txt - subdomain - password This still checks `X-Api-Key` and `X-Api-User` for backwards compatibility. If a user is provided we'll still check it, but it is now optional. This should address most of https://github.com/joohoi/acme-dns/issues/77 too. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>