[PR #145] [MERGED] Fix responses to be more standards compliant #321

New issue

Closed

opened 2026-03-13 16:17:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:17:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/145
Author: @joohoi
Created: 2/3/2019
Status: ✅ Merged
Merged: 2/3/2019
Merged by: @joohoi

Base: master ← Head: dnsfixes

📝 Commits (4)

6a8cbdb Handle OPT questions (EDNS)
9f512f5 Handle authoritative bit, and append SOA for authoritative NXDOMAIN responses
d61fc9e Changelog entry
bbce3a6 Fix linter errors

📊 Changes

3 files changed (+96 additions, -29 deletions)

View changed files

📝 README.md (+4 -2)
📝 dns.go (+37 -6)
📝 dns_test.go (+55 -21)

📄 Description

This PR adds correct handling for:

EDNS requests, by indicating that EDNS isn't implemented: FORMERRsome
Figure out if some of the parent domains exists in case of NXDOMAIN and set authoritative bit and append SOA record for caching.
If other than requested records exist for domain, return an empty NOERROR response.

Fixes #127

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/145 **Author:** [@joohoi](https://github.com/joohoi) **Created:** 2/3/2019 **Status:** ✅ Merged **Merged:** 2/3/2019 **Merged by:** [@joohoi](https://github.com/joohoi) **Base:** `master` ← **Head:** `dnsfixes` --- ### 📝 Commits (4) - [`6a8cbdb`](https://github.com/acme-dns/acme-dns/commit/6a8cbdb8796548d0052d791b9a2ac1c5f540b059) Handle OPT questions (EDNS) - [`9f512f5`](https://github.com/acme-dns/acme-dns/commit/9f512f5db724ff22125ec394fcc5ce41b3a90535) Handle authoritative bit, and append SOA for authoritative NXDOMAIN responses - [`d61fc9e`](https://github.com/acme-dns/acme-dns/commit/d61fc9e251dec89422622001850c74788d02e0e0) Changelog entry - [`bbce3a6`](https://github.com/acme-dns/acme-dns/commit/bbce3a6812ad3768fd8ace0f569e3ff9a12a66a3) Fix linter errors ### 📊 Changes **3 files changed** (+96 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+4 -2) 📝 `dns.go` (+37 -6) 📝 `dns_test.go` (+55 -21) </details> ### 📄 Description This PR adds correct handling for: - EDNS requests, by indicating that EDNS isn't implemented: FORMERRsome - Figure out if some of the parent domains exists in case of NXDOMAIN and set authoritative bit and append SOA record for caching. - If other than requested records exist for domain, return an empty NOERROR response. Fixes #127 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>