[PR #132] small Dockerfile improvements #312

New issue

Open

opened 2026-03-13 16:17:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:17:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/132
Author: @schue30
Created: 12/25/2018
Status: 🔄 Open

Base: master ← Head: master

📝 Commits (10+)

6fd21c3 improve Dockerfile
19750e8 update docker-compose.yml to use the ports of the updated Dockerfile
865eb6e Merge branch 'master' into master
6282e35 update go to version 1.11.5 and acme-dns to release 0.7 + fix port replacement
e17aeb8 add the Dockerfile changes to the README
4f1b160 Merge branch 'master' into master
482722a update dockerfile to golang 1.12 + alpine to 3.9 + acme-dns to v0.7.2
939d26b add docker-compose migration path to the README.md file
2ab81f3 fix acme-dns version definition + change cmd to entrypoint + use install command in dockerfile
f6a5ab2 use alpine instead of scretch base image + add healthcheck

📊 Changes

3 files changed (+66 additions, -26 deletions)

View changed files

📝 Dockerfile (+24 -14)
📝 README.md (+34 -7)
📝 docker-compose.yml (+8 -5)

📄 Description

This PR improves the following points in the Dockerfile:

build exact git tag instead of the current master
update of the current golang build environment from 1.9.2 to 1.11.4
use scratch instead of an alpine image
run container as user 1000 (instead of root)
change listening ports from system ports 53, 80, 443 to 5353, 8080, 8443

WARNING - this PR contains breaking changes in the Dockerfile
The container that is started from the image that is built from this Dockerfile is running as user 1000 instead of root (0). As a non root user cannot (per default) listen on system ports (<1024), I had to change them to ones that are higher than 1024. In this case 5353, 8080.
Updates from older versions should not be a problem, as long as the user 1000 or the group 0 has read permissions on the config file, write permissions on the sqlite db file and the listening ports are higher than 1024.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/132 **Author:** [@schue30](https://github.com/schue30) **Created:** 12/25/2018 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`6fd21c3`](https://github.com/acme-dns/acme-dns/commit/6fd21c3c9c1b74efd0eb2a58052323b730375c66) improve Dockerfile - [`19750e8`](https://github.com/acme-dns/acme-dns/commit/19750e89d110ac61b27bc997de675a96048c0293) update docker-compose.yml to use the ports of the updated Dockerfile - [`865eb6e`](https://github.com/acme-dns/acme-dns/commit/865eb6efe8cfeac6f6a3033d00c8708b797e6ebd) Merge branch 'master' into master - [`6282e35`](https://github.com/acme-dns/acme-dns/commit/6282e359e1320c8b6375f5be3c59dfcac28185fe) update go to version 1.11.5 and acme-dns to release 0.7 + fix port replacement - [`e17aeb8`](https://github.com/acme-dns/acme-dns/commit/e17aeb82235751971a9511ae830128a39fbb8889) add the Dockerfile changes to the README - [`4f1b160`](https://github.com/acme-dns/acme-dns/commit/4f1b160a665ea6d02781509a164b8a2c6e3ec4a6) Merge branch 'master' into master - [`482722a`](https://github.com/acme-dns/acme-dns/commit/482722a15722933ea1d3ac72ec60f6fcd2bc3127) update dockerfile to golang 1.12 + alpine to 3.9 + acme-dns to v0.7.2 - [`939d26b`](https://github.com/acme-dns/acme-dns/commit/939d26bf024c7765d8708d6c0e19077d58f0d1ca) add docker-compose migration path to the README.md file - [`2ab81f3`](https://github.com/acme-dns/acme-dns/commit/2ab81f3cf50a838825dad56cbfff3a2dce91f698) fix acme-dns version definition + change cmd to entrypoint + use install command in dockerfile - [`f6a5ab2`](https://github.com/acme-dns/acme-dns/commit/f6a5ab2b8918a4a47f4fa0d2ee1a1210f920d6df) use alpine instead of scretch base image + add healthcheck ### 📊 Changes **3 files changed** (+66 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+24 -14) 📝 `README.md` (+34 -7) 📝 `docker-compose.yml` (+8 -5) </details> ### 📄 Description This PR improves the following points in the Dockerfile: - build exact git tag instead of the current master - update of the current golang build environment from 1.9.2 to 1.11.4 - use scratch instead of an alpine image - run container as user 1000 (instead of root) - change listening ports from system ports 53, 80, 443 to 5353, 8080, 8443 **WARNING** - this PR contains breaking changes in the Dockerfile The container that is started from the image that is built from this Dockerfile is running as user 1000 instead of root (0). As a non root user cannot (per default) listen on system ports (<1024), I had to change them to ones that are higher than 1024. In this case 5353, 8080. Updates from older versions should not be a problem, as long as the user 1000 or the group 0 has read permissions on the config file, write permissions on the sqlite db file and the listening ports are higher than 1024. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>