[PR #130] [MERGED] Fix Docker instructions and add option to bind both DNS to both UDP and TCP #307

New issue

Closed

opened 2026-03-13 16:16:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:16:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/130
Author: @joohoi
Created: 12/13/2018
Status: ✅ Merged
Merged: 12/13/2018
Merged by: @joohoi

Base: master ← Head: both_dns_proto

📝 Commits (1)

292ec87 Fix Docker instructions and add option to bind both UDP and TCP DNS listeners

📊 Changes

6 files changed (+38 additions, -12 deletions)

View changed files

📝 Dockerfile (+1 -0)
📝 README.md (+7 -2)
📝 config.cfg (+5 -4)
📝 docker-compose.yml (+1 -0)
📝 main.go (+23 -5)
📝 main_test.go (+1 -1)

📄 Description

Fixes the Docker documentation, provided docker-compose.yml and adds the config option (also the new default) to bind DNS listener to both - UDP and TCP ports.

Fixes: #129
Fixes: #80

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/130 **Author:** [@joohoi](https://github.com/joohoi) **Created:** 12/13/2018 **Status:** ✅ Merged **Merged:** 12/13/2018 **Merged by:** [@joohoi](https://github.com/joohoi) **Base:** `master` ← **Head:** `both_dns_proto` --- ### 📝 Commits (1) - [`292ec87`](https://github.com/acme-dns/acme-dns/commit/292ec87b59f7497babd9cf0691a07f10b9a1acbd) Fix Docker instructions and add option to bind both UDP and TCP DNS listeners ### 📊 Changes **6 files changed** (+38 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+1 -0) 📝 `README.md` (+7 -2) 📝 `config.cfg` (+5 -4) 📝 `docker-compose.yml` (+1 -0) 📝 `main.go` (+23 -5) 📝 `main_test.go` (+1 -1) </details> ### 📄 Description Fixes the Docker documentation, provided `docker-compose.yml` and adds the config option (also the new default) to bind DNS listener to both - UDP and TCP ports. Fixes: #129 Fixes: #80 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>