[PR #122] [MERGED] Better error handling in goroutines #303

New issue

Closed

opened 2026-03-13 16:16:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:16:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/122
Author: @joohoi
Created: 10/30/2018
Status: ✅ Merged
Merged: 10/30/2018
Merged by: @joohoi

Base: master ← Head: err_on_dns

📝 Commits (3)

6bc538b More robust goroutine error handling using channels
8240af0 Fix tests and make startup log msg saner
2d945cc Clarification to README and config file

📊 Changes

6 files changed (+55 additions, -19 deletions)

View changed files

📝 .travis.yml (+1 -0)
📝 README.md (+3 -1)
📝 config.cfg (+3 -1)
📝 main.go (+36 -7)
📝 main_test.go (+12 -1)
📝 util.go (+0 -9)

📄 Description

This PR adds a error handling mechanism to spawned goroutines using channels. This allows printing error messages when spawning DNS server goroutine if it encounters an error.

Fixes: #118

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/122 **Author:** [@joohoi](https://github.com/joohoi) **Created:** 10/30/2018 **Status:** ✅ Merged **Merged:** 10/30/2018 **Merged by:** [@joohoi](https://github.com/joohoi) **Base:** `master` ← **Head:** `err_on_dns` --- ### 📝 Commits (3) - [`6bc538b`](https://github.com/acme-dns/acme-dns/commit/6bc538b76c5e7c37425a8f39bd9f08b40f005381) More robust goroutine error handling using channels - [`8240af0`](https://github.com/acme-dns/acme-dns/commit/8240af00409f31aaef4c09f45a9f536290844af6) Fix tests and make startup log msg saner - [`2d945cc`](https://github.com/acme-dns/acme-dns/commit/2d945cc796b275608dce03494d9864ce950bab7a) Clarification to README and config file ### 📊 Changes **6 files changed** (+55 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+1 -0) 📝 `README.md` (+3 -1) 📝 `config.cfg` (+3 -1) 📝 `main.go` (+36 -7) 📝 `main_test.go` (+12 -1) 📝 `util.go` (+0 -9) </details> ### 📄 Description This PR adds a error handling mechanism to spawned goroutines using channels. This allows printing error messages when spawning DNS server goroutine if it encounters an error. Fixes: #118 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>