[PR #101] [MERGED] Better error messages for missing DB config values #296

New issue

Closed

opened 2026-03-13 16:16:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:16:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/101
Author: @joohoi
Created: 8/12/2018
Status: ✅ Merged
Merged: 8/12/2018
Merged by: @joohoi

Base: master ← Head: err-msgs

📝 Commits (2)

c920e31 Better error messages for missing DB config values
1f24a5f Make linter happy

📊 Changes

2 files changed (+39 additions, -1 deletions)

View changed files

📝 util.go (+17 -1)
📝 util_test.go (+22 -0)

📄 Description

Prior to this PR, if database configuration values are missing, acme-dns errors with confusing error messages from database/sql like:

ERRO[0000] Could not open database [sql: unknown driver "" (forgotten import?)]

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/101 **Author:** [@joohoi](https://github.com/joohoi) **Created:** 8/12/2018 **Status:** ✅ Merged **Merged:** 8/12/2018 **Merged by:** [@joohoi](https://github.com/joohoi) **Base:** `master` ← **Head:** `err-msgs` --- ### 📝 Commits (2) - [`c920e31`](https://github.com/acme-dns/acme-dns/commit/c920e3111fd3ed685cdf755240582fa4bdbb1ef9) Better error messages for missing DB config values - [`1f24a5f`](https://github.com/acme-dns/acme-dns/commit/1f24a5f9aafbbd2f66c5feb63d4fdf452b2c75e8) Make linter happy ### 📊 Changes **2 files changed** (+39 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `util.go` (+17 -1) 📝 `util_test.go` (+22 -0) </details> ### 📄 Description Prior to this PR, if database configuration values are missing, acme-dns errors with confusing error messages from `database/sql` like: ``` ERRO[0000] Could not open database [sql: unknown driver "" (forgotten import?)] ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>