[PR #50] [MERGED] Properly parse r.RemoteAddr #262

New issue

Closed

opened 2026-03-13 16:14:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:14:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/50
Author: @joohoi
Created: 3/14/2018
Status: ✅ Merged
Merged: 3/14/2018
Merged by: @joohoi

Base: master ← Head: fix_remoteaddr

📝 Commits (3)

709af4a Properly parse r.RemoteAddr
1e6793a Add tests, and fix net.ParseCIDR issues with IPv6 addresses enclosed in brackets
000f782 Merge branch 'master' into fix_remoteaddr

📊 Changes

4 files changed (+48 additions, -3 deletions)

View changed files

📝 acmetxt.go (+2 -2)
📝 auth.go (+7 -1)
➕ auth_test.go (+33 -0)
📝 util.go (+6 -0)

📄 Description

RemoteAddr in http.Request is in form of HOST:PORT, so the value needed to be split before comparing to the CIDR masks in validation code.

Fixes: #45

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/50 **Author:** [@joohoi](https://github.com/joohoi) **Created:** 3/14/2018 **Status:** ✅ Merged **Merged:** 3/14/2018 **Merged by:** [@joohoi](https://github.com/joohoi) **Base:** `master` ← **Head:** `fix_remoteaddr` --- ### 📝 Commits (3) - [`709af4a`](https://github.com/acme-dns/acme-dns/commit/709af4ab26b04b6bf55b31b65f79eeb6ecf868d3) Properly parse r.RemoteAddr - [`1e6793a`](https://github.com/acme-dns/acme-dns/commit/1e6793a6cd0ca7dc6934480eaa27e390315c4c3f) Add tests, and fix net.ParseCIDR issues with IPv6 addresses enclosed in brackets - [`000f782`](https://github.com/acme-dns/acme-dns/commit/000f782001f85449cf27cb8c2fbfdfe210fb02db) Merge branch 'master' into fix_remoteaddr ### 📊 Changes **4 files changed** (+48 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `acmetxt.go` (+2 -2) 📝 `auth.go` (+7 -1) ➕ `auth_test.go` (+33 -0) 📝 `util.go` (+6 -0) </details> ### 📄 Description RemoteAddr in `http.Request` is in form of HOST:PORT, so the value needed to be split before comparing to the CIDR masks in validation code. Fixes: #45 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>