[PR #29] [MERGED] Support for multiple TXT records per subdomain #253

New issue

Closed

opened 2026-03-13 16:13:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 16:13:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns/pull/29
Author: @joohoi
Created: 1/20/2018
Status: ✅ Merged
Merged: 1/22/2018
Merged by: @joohoi

Base: master ← Head: multi_txt

📝 Commits (4)

ac73a2a Support for multiple TXT records per subdomain and database upgrade functionality
3f25615 Linter fixes
e9bc7c7 Make sure the database upgrade routine works for PostgreSQL
44d30c1 Move subdomain query outside of the upgrade transaction

📊 Changes

6 files changed (+199 additions, -71 deletions)

View changed files

📝 acmetxt.go (+1 -2)
📝 db.go (+162 -31)
📝 db_test.go (+29 -33)
📝 dns.go (+4 -4)
📝 main.go (+2 -0)
📝 types.go (+1 -1)

📄 Description

Functionality for having two rolling TXT records per subdomain is now added. This fixes the issue with domain.tld and *.domain.tld in the same certificate, as they would point to the same subdomain using the CNAME. The oldest one of the two is always updated.

Database structure changed, but the old databases (with the exception of TXT records) will be upgraded, so all the credentials will be saved.

Fixes: #28

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns/pull/29 **Author:** [@joohoi](https://github.com/joohoi) **Created:** 1/20/2018 **Status:** ✅ Merged **Merged:** 1/22/2018 **Merged by:** [@joohoi](https://github.com/joohoi) **Base:** `master` ← **Head:** `multi_txt` --- ### 📝 Commits (4) - [`ac73a2a`](https://github.com/acme-dns/acme-dns/commit/ac73a2ab9bd4b61149d7797c55ec461723f4e7a2) Support for multiple TXT records per subdomain and database upgrade functionality - [`3f25615`](https://github.com/acme-dns/acme-dns/commit/3f256150caa77b6d18d0200af065b71244c25780) Linter fixes - [`e9bc7c7`](https://github.com/acme-dns/acme-dns/commit/e9bc7c7af41bfde7360fe34a521dd72cf91e544d) Make sure the database upgrade routine works for PostgreSQL - [`44d30c1`](https://github.com/acme-dns/acme-dns/commit/44d30c1c63636190fd8237b74d88369155216244) Move subdomain query outside of the upgrade transaction ### 📊 Changes **6 files changed** (+199 additions, -71 deletions) <details> <summary>View changed files</summary> 📝 `acmetxt.go` (+1 -2) 📝 `db.go` (+162 -31) 📝 `db_test.go` (+29 -33) 📝 `dns.go` (+4 -4) 📝 `main.go` (+2 -0) 📝 `types.go` (+1 -1) </details> ### 📄 Description Functionality for having two rolling TXT records per subdomain is now added. This fixes the issue with `domain.tld` and `*.domain.tld` in the same certificate, as they would point to the same subdomain using the CNAME. The oldest one of the two is always updated. Database structure changed, but the old databases (with the exception of TXT records) will be upgraded, so all the credentials will be saved. Fixes: #28 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>