starred/acme-dns-client
1
0
Fork 0
mirror of https://github.com/acme-dns/acme-dns-client.git synced 2026-04-25 21:35:57 +03:00
Code Issues 20 Projects Releases 3 Packages Wiki Activity

[PR #2] [MERGED] Fix register omitting -allow causing 400 invalid_allowfrom_cidr #19

New issue
Closed
opened 2026-03-13 16:27:07 +03:00 by kerem · 0 comments
kerem commented 2026-03-13 16:27:07 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/acme-dns/acme-dns-client/pull/2
Author: @JonathanGawrych
Created: 2/15/2021
Status: ✅ Merged
Merged: 2/16/2021
Merged by: @joohoi

Base: master ← Head: jag/fix-empty-allow-from

📝 Commits (1)

  • e17ad9a Fix register omitting -allow causing 400 invalid_allowfrom_cidr

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 pkg/client/register.go (+4 -1)

📄 Description

If you attempt to register to joohoi/acme-dns server without specifying an allow flag, the request sent to the server is an array containing the empty string [""], which responds with 400 invalid_allowfrom_cidr. Instead, this fix makes omitting allow send an empty array [] which allows registration to work correctly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/acme-dns/acme-dns-client/pull/2 **Author:** [@JonathanGawrych](https://github.com/JonathanGawrych) **Created:** 2/15/2021 **Status:** ✅ Merged **Merged:** 2/16/2021 **Merged by:** [@joohoi](https://github.com/joohoi) **Base:** `master` ← **Head:** `jag/fix-empty-allow-from` --- ### 📝 Commits (1) - [`e17ad9a`](https://github.com/acme-dns/acme-dns-client/commit/e17ad9a153cf34dbd972d9d59f41294fb296070d) Fix register omitting -allow causing 400 invalid_allowfrom_cidr ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/client/register.go` (+4 -1) </details> ### 📄 Description If you attempt to register to joohoi/acme-dns server without specifying an allow flag, the request sent to the server is an array containing the empty string `[""]`, which responds with 400 `invalid_allowfrom_cidr`. Instead, this fix makes omitting allow send an empty array `[]` which allows registration to work correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-13 16:27:07 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
release03
fix_wildcard
fix_goreleaser
prepare_v0.2
v0.3
v0.2
v0.1
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

  
question

   
question
No labels
pull-request
question
question
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/acme-dns-client#19
No description provided.