mirror of
https://github.com/tzapu/WiFiManager.git
synced 2026-04-27 00:55:52 +03:00
[GH-ISSUE #1135] Use ESP's logging API #972
Labels
No labels
📶 WiFi
🕸️ HTTP
Branch
DEV Help Wanted
Discussion
Documentation
ESP32
Example
Good First Issue
Hotfix
In Progress
Incomplete
Needs Feeback
Priority
QA
Question
Task
Upstream/Dependancy
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/WiFiManager#972
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nikeee on GitHub (Oct 19, 2020).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1135
Basic Infos
Hardware
WiFimanager Branch/Release:
Esp8266/Esp32:
ESP Core Version: 2.4.0, staging
Description
Currently, WiFiManager uses a custom logging infrastructure to log stuff:
github.com/tzapu/WiFiManager@e454c9969a/WiFiManager.h (L561-L594)However, ESP-IDF offers an API for logging (which is also part of Arduino):
https://thingpulse.com/esp32-logging/
It offers tagging (which would be
*WM) as well as setting the verbosity at compile time as well as runtime.Is this something that could be used? If so I'd be hapy to do a PR.
@tablatronix commented on GitHub (Oct 19, 2020):
Definitely , I have thought about that, if you can think of a way to simply modify the outputs of the existing logger functions?
I would rather not replace them in case we ever support another micro etc.
Maybe just swap wm serial output via a define to ESP_ logs instead, and maybe we can add a variable prefix to pass also instead of *wm
Alternative would be to redefine the logging functions at compile time. But I have a few weird ones.. Like key,value pairs