mirror of
https://github.com/tzapu/WiFiManager.git
synced 2026-04-27 09:05:56 +03:00
[GH-ISSUE #1029] Alternate method for startWebPortal #876
Labels
No labels
📶 WiFi
🕸️ HTTP
Branch
DEV Help Wanted
Discussion
Documentation
ESP32
Example
Good First Issue
Hotfix
In Progress
Incomplete
Needs Feeback
Priority
QA
Question
Task
Upstream/Dependancy
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/WiFiManager#876
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @GiPe66 on GitHub (Apr 4, 2020).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1029
Hi,
It should be nice to have an alternate method startWebPortal(const char *title) to specify the title line of the menu when portal is in web mode.
In this case the local IP address si displayed and may not be necessary considering it is also displayed in the footer. Replacing it by a text given when starting the webPortal may give a better focussed information for the application.
Also the current startWebPortal() will go on giving the localIp address.
Thanks for your attention.
@tablatronix commented on GitHub (Apr 5, 2020):
The ip only shows if you do not use a hostname, so thats an option atm
@GiPe66 commented on GitHub (Apr 5, 2020):
@tablatronix, Thanks for the fast answer.
If I well understand, in the code
str.replace(FPSTR(T_v),configPortalActive ? _apName : WiFi.localIP().toString()); // use ip if ap is not active for headingas I am in webPortal mode, configPortalActive is false, so I always get the IP address.
@tablatronix commented on GitHub (Apr 5, 2020):
What version is this? Ill check
@tablatronix commented on GitHub (Apr 5, 2020):
Looks like I never implemented that, oops
@GiPe66 commented on GitHub (Apr 6, 2020):
Maybe a method to set a name should be simpler and enough...
@tablatronix commented on GitHub (Apr 6, 2020):
I will work on it tomorrow , but it will be development branch only
@GiPe66 commented on GitHub (Apr 6, 2020):
No problem, I'm only using this branch considering the non-blocking mode.
Thanks for all this nice job.
@tablatronix commented on GitHub (Apr 6, 2020):
hmm best option would be to allow replacing the entire header, but it only is used on the root page.
const char HTTP_ROOT_MAIN[] PROGMEM = "<h1>{v}</h1><h3>WiFiManager</h3>";Or callout?
@GiPe66 commented on GitHub (Apr 6, 2020):
Yes, your option seems interesting and gives more flexibility to customize the pages, mainly avoiding the
<h1>tag. Thanks.@tablatronix commented on GitHub (Apr 6, 2020):
I am tempted also to change H1 to the user title, and the h3 to the hostname/ip
@GiPe66 commented on GitHub (Apr 6, 2020):
H1 is really BIG... It should be nice to let the user define the header and the size of the font; So your proposal to possibly replace the full header is for me a good option.
@tablatronix commented on GitHub (Apr 6, 2020):
Well the good thing about development branch is it is easy for you to touch anything in strings without touching code and you can change it all. Problem is when you want to change stuff on the fly, these are mostly constants in flash, soo that becomes a problem