[GH-ISSUE #1013] deprecate _shouldBreakAfterConfig and wifisavecallback #860

New issue

Open

opened 2026-02-28 01:27:22 +03:00 by kerem · 1 comment

kerem commented

2026-02-28 01:27:22 +03:00

Owner

Originally created by @tablatronix on GitHub (Feb 25, 2020).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1013

ok this is confusing and needs to go.

There are 2 requirements here

If saving wifi and fail, do we stop configportal ?
If not saving wifi and param only, do we stop configportal

We need a callback or 2 to replace savewifi, as this is the only one and is also called for param save, it is also only called if _shouldBreakAfterConfig which is bad.

We also need to pass a status to the wifisave callback and closure so user knows if wifi was successful, but with skippable wifi, what do we do ?

If saving wifi we always stop config portal also. as it must to connect to sta..

Originally created by @tablatronix on GitHub (Feb 25, 2020). Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1013 ok this is confusing and needs to go. There are 2 requirements here If saving wifi and fail, do we stop configportal ? If not saving wifi and param only, do we stop configportal We need a callback or 2 to replace savewifi, as this is the only one and is also called for param save, it is also only called if `_shouldBreakAfterConfig` which is bad. We also need to pass a status to the wifisave callback and closure so user knows if wifi was successful, but with skippable wifi, what do we do ? If saving wifi we always stop config portal also. as it must to connect to sta..

kerem added the

enhancement

Discussion

labels

2026-02-28 01:27:22 +03:00

kerem commented

2026-02-28 01:27:23 +03:00

Author

Owner

@tablatronix commented on GitHub (Feb 26, 2020):

I think we can just change the return result to an enum instead of bool and add multi state, that is the easiest fix.

@tablatronix commented on GitHub (Feb 26, 2020): I think we can just change the return result to an enum instead of bool and add multi state, that is the easiest fix.