mirror of
https://github.com/tzapu/WiFiManager.git
synced 2026-04-27 09:05:56 +03:00
[GH-ISSUE #111] signal strength meter icons #85
Labels
No labels
📶 WiFi
🕸️ HTTP
Branch
DEV Help Wanted
Discussion
Documentation
ESP32
Example
Good First Issue
Hotfix
In Progress
Incomplete
Needs Feeback
Priority
QA
Question
Task
Upstream/Dependancy
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/WiFiManager#85
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tablatronix on GitHub (Feb 26, 2016).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/111
I was throwing this together for myself and will probably commit to my fork and do a PR, thoughts ?
it is fairly small, slightly larger than the lock icon alone and the markup is also small, only a few classes on elements.
But i do not know what is acceptable, could easily be changed to font svg icons or remove transparency to increase, decrease size, resolutions, as far as retina goes, I have no idea what the minimum size for icons should be, these might look terrible, i have not tested yet.
(current lock icon is 214 bytes, so this adds net total of 619 bytes to mem)
@tzapu commented on GitHub (Feb 27, 2016):
these looks awesome, really nice work
for retina, they need to be about double the size they are set at, so 20px for a 10px shown image.
about 14px seems to work ok in relation to the current font size
really excited for this, looks really nice 👍
@tablatronix commented on GitHub (Mar 25, 2016):
ok so I have a final version coming.
I few things I found.
base64 encoding does not support @2x image scaling.
And I cannot just use large images and scale down for non retina, because then it is blurry, blegh
So I had to include 16px sprites, and a 32px sprite for 192ppi display using a @media selector, which I then half scale, so the sprite coords do not have to be duplicated. It works, much crisper icons on IOS safari and chrome, I have not the hardware to test on android to see if it gets blurry or not
If you don't want the extra progmem space, you can easily comment the hi res out, no big deal.
All in all all entire style string is ~1.4k, with negligible markup added to the html.
I also added accessibility title and aria-labels to the icon container since they are background images and not very screen reader compliant by default. This also allows hover text of the quality nicely for more detail.
icons can be left or right aligned with respect to the SSID link,
leftorrightclasses on the parent div.There is also an
invertclass for that to invert the icons to white.@tablatronix commented on GitHub (Jun 4, 2016):
any chance to test?
@tzapu commented on GitHub (Jun 5, 2016):
hi mate, sorry for taking so long, had and still have a few long and busy weeks.
i hope to make more progress next week
@tablatronix commented on GitHub (Feb 8, 2017):
any chance in hell of merging this?
want me to pr to development?
@tzapu commented on GitHub (Feb 9, 2017):
hi, sure, if you could pr it to dev it would be perfect as some things have changed
cheers
@tablatronix commented on GitHub (Feb 10, 2017):
Do you have tagged issues or a milestone of the changes or plans for dev or a single issue even?
@tablatronix commented on GitHub (Aug 28, 2017):