wifi&refresh #822

New issue

Closed

opened 2026-02-28 01:27:12 +03:00 by kerem · 4 comments

kerem commented

2026-02-28 01:27:12 +03:00

Owner

Originally created by @dontsovcmc on GitHub (Nov 15, 2019).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/968

If better to remove dublicate functions to decrease code size. I think /0wifi is excess, cause we can change button code:
"<form action='/wifi?refresh=1' method='get'><button>Configure WiFi</button></form><br/>\n", // MENU_WIFI

no scan will be /wifi without argument:
"<form action='/wifi' method='get'><button>Configure WiFi (No Scan)</button></form><br/>\n", // MENU_WIFINOSCAN

Originally created by @dontsovcmc on GitHub (Nov 15, 2019). Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/968 If better to remove dublicate functions to decrease code size. I think /0wifi is excess, cause we can change button code: `"<form action='/wifi?refresh=1' method='get'><button>Configure WiFi</button></form><br/>\n", // MENU_WIFI` no scan will be /wifi without argument: `"<form action='/wifi' method='get'><button>Configure WiFi (No Scan)</button></form><br/>\n", // MENU_WIFINOSCAN`

kerem closed this issue

2026-02-28 01:27:12 +03:00

kerem commented

2026-02-28 01:27:13 +03:00

Author

Owner

@tablatronix commented on GitHub (Nov 15, 2019):

it is legacy

@tablatronix commented on GitHub (Nov 15, 2019): it is legacy

kerem commented

2026-02-28 01:27:13 +03:00

Author

Owner

@dontsovcmc commented on GitHub (Nov 15, 2019):

WiFiManager has bad architecture, any customization are hard to do. I want to see anybody who use this methods outside WiFiManager source code. It's difficult to refactor library if we have a lot of unused features.

@dontsovcmc commented on GitHub (Nov 15, 2019): WiFiManager has bad architecture, any customization are hard to do. I want to see anybody who use this methods outside WiFiManager source code. It's difficult to refactor library if we have a lot of unused features.

kerem commented

2026-02-28 01:27:13 +03:00

Author

Owner

@tablatronix commented on GitHub (Nov 15, 2019):

You keep saying "refactor" refator what?
What needs refactoring, I just refactored the entire thing to start organizing for future updates, v0 has no abstraction at all.

@tablatronix commented on GitHub (Nov 15, 2019): You keep saying "refactor" refator what? What needs refactoring, I just refactored the entire thing to start organizing for future updates, v0 has no abstraction at all.

kerem commented

2026-02-28 01:27:13 +03:00

Author

Owner

@dontsovcmc commented on GitHub (Nov 15, 2019):

I mean less code, less errors only =)

@dontsovcmc commented on GitHub (Nov 15, 2019): I mean less code, less errors only =)