[GH-ISSUE #967] configPortalHasTimeout dependings #820

New issue

Open

opened 2026-02-28 01:27:12 +03:00 by kerem · 2 comments

kerem commented

2026-02-28 01:27:12 +03:00

Owner

Originally created by @dontsovcmc on GitHub (Nov 15, 2019).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/967

I can't understand, why we need to call handleRequest() in root handle to reset _webPortalAccessed?
configPortal timeout start point should be the time when it starts. But now we have another timepoint - when portal opened by client.
Why does it needed?!

If we make timeout only from function call, we simplify configPortalHasTimeout() function and remove handleRequest().

Originally created by @dontsovcmc on GitHub (Nov 15, 2019). Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/967 I can't understand, why we need to call handleRequest() in root handle to reset _webPortalAccessed? configPortal timeout start point should be the time when it starts. But now we have another timepoint - when portal opened by client. Why does it needed?! If we make timeout only from function call, we simplify configPortalHasTimeout() function and remove handleRequest().

kerem commented

2026-02-28 01:27:13 +03:00

Author

Owner

@tablatronix commented on GitHub (Nov 15, 2019):

That is how I hacked the webactive timeout, it was easier than adding new variables for something that is experimental and not even enabled by default. It is a bit of a kludge, it also prevents me from having to modify the timeout evaluation, easier to just bump start time, we do not actually need it..

@tablatronix commented on GitHub (Nov 15, 2019): That is how I hacked the webactive timeout, it was easier than adding new variables for something that is experimental and not even enabled by default. It is a bit of a kludge, it also prevents me from having to modify the timeout evaluation, easier to just bump start time, we do not actually need it..

kerem commented

2026-02-28 01:27:13 +03:00

Author

Owner

@tablatronix commented on GitHub (Nov 15, 2019):

https://github.com/tzapu/WiFiManager/blob/development/WiFiManager.h#L246

@tablatronix commented on GitHub (Nov 15, 2019): https://github.com/tzapu/WiFiManager/blob/development/WiFiManager.h#L246