mirror of
https://github.com/tzapu/WiFiManager.git
synced 2026-04-27 00:55:52 +03:00
[GH-ISSUE #949] Reset Setting including Spiffs.fomart -> ESP8266 #802
Labels
No labels
📶 WiFi
🕸️ HTTP
Branch
DEV Help Wanted
Discussion
Documentation
ESP32
Example
Good First Issue
Hotfix
In Progress
Incomplete
Needs Feeback
Priority
QA
Question
Task
Upstream/Dependancy
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/WiFiManager#802
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bgersmann on GitHub (Sep 26, 2019).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/949
Basic Infos
Hardware
WiFimanager Branch/Release:
Esp8266/Esp32:
Hardware: ESP-12e, esp01, esp25
ESP Core Version: 2.4.0, staging
Description
Hi,
I'm using a local copy of the library, because I added a "Spiffs.format()" to the reset function.
Is there any easy way to do this without the local copy? Could you maybe add it as an optional parameter to the reset function?
Thanks in advance.
@tablatronix commented on GitHub (Sep 26, 2019):
hmm, WM does not use Spiffs, so it would make no sense to add this.
Maybe use a callout to user code?
@Joennuh commented on GitHub (Sep 26, 2019):
Some examples DO use SPIFFS to save extra parameters. Like this one: https://github.com/tzapu/WiFiManager/blob/master/examples/AutoConnectWithFSParameters/AutoConnectWithFSParameters.ino
An SPIFFS reset function would be nice but I believe it is not absolutely necessary for the core functionality of WiFiManager.
@tablatronix commented on GitHub (Sep 26, 2019):
yeah examples.
I am going to try to add a define or auto detect spiffs and do it like that
@tablatronix commented on GitHub (Sep 26, 2019):
Ok so WiFiManager::erase(bool opt) already exists and has an optional flag
in esp32 this can erase NVS
In esp8266 I can make it erase spiffs ( if spiffs was compiled and is incuded etc )
I just have to figure out error handling and stuff
@tablatronix commented on GitHub (Sep 26, 2019):
I think I will just leave it seperate, so you have to call it twice for now
@tablatronix commented on GitHub (Sep 26, 2019):
Will have to test of course, as of now they are seperate, I can work on combining them later if they work and I can figure out error handling.
as of now
on esp8266
erase()will erase wificonfig via "ESP.eraseConfig()" or sector wipe ifWM_FIXERASECONFIGerase(true)will erase spiffs ONLYon esp32
erase()will erase wifi config via disconnecterase(true)will erase NVS ifWM_ERASE_NVSandnvs_flash_hAll will return bool result
@tablatronix commented on GitHub (Sep 26, 2019):
you can test with this
@tablatronix commented on GitHub (Sep 26, 2019):
hmm not working, let me fix it
@tablatronix commented on GitHub (Sep 26, 2019):
of course it wont work, doh, I cannot detect spiffs defined in sketch.. ugh C++ linker is so anoying sometimes
@Ruandv commented on GitHub (Jan 15, 2020):
@tablatronix is this something that I can have a look at for you? Can i maybe put it as part of an exampe?
@tablatronix commented on GitHub (Jan 15, 2020):
Well I was hoping to have it automatic but I do not see any way to do it ill have to add some flags or params to let users do it instead
@Ruandv commented on GitHub (Jan 15, 2020):
Suggestion:
Why don't you rename the
bool WiFiManager::erase(bool opt)tobool WiFiManager::format()?then
bool WiFiManager::erase()will still only doWiFi_eraseConfigandbool WiFiManager::format()will then go and dospiffs.format()and callWiFi_eraseConfig@Ruandv commented on GitHub (Feb 22, 2020):
Is there any objections to my suggestion above? If not then I'm willing to try and implement it.
@tablatronix commented on GitHub (Feb 22, 2020):
Yeah but that's not really the problem, the problem is this only works with spiffs enabled. And I cannot see how we can determine that since user can do it themselves in their code or other librarys
@Ruandv commented on GitHub (Feb 22, 2020):
Ok thanks now I understand the bigger problem.
On Sat, 22 Feb 2020, 08:20 Shawn A, notifications@github.com wrote: