[GH-ISSUE #861] Refactor: WiFiManagerParameter remove id #726

Open
opened 2026-02-28 01:26:46 +03:00 by kerem · 5 comments
Owner

Originally created by @dontsovcmc on GitHub (Mar 31, 2019).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/861

Why user needs to know Parameter id?
You can hidden generate them as 'p1', 'p2' and parse by server.

Originally created by @dontsovcmc on GitHub (Mar 31, 2019). Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/861 Why user needs to know Parameter id? You can hidden generate them as 'p1', 'p2' and parse by server.
Author
Owner

@tablatronix commented on GitHub (Mar 31, 2019):

This is somewhat implemented already using token capital I instead, obviously a param constructor without id needs to be added, not really a major issue and user might need to know which param before hand, making it optional would be nice and simplify params. I started saying the same thing in another issue, too many arguments to just add params and constructors are confusing, cant find it

<!-- gh-comment-id:478344416 --> @tablatronix commented on GitHub (Mar 31, 2019): This is somewhat implemented already using token capital I instead, obviously a param constructor without id needs to be added, not really a major issue and user might need to know which param before hand, making it optional would be nice and simplify params. I started saying the same thing in another issue, too many arguments to just add params and constructors are confusing, cant find it
Author
Owner

@tablatronix commented on GitHub (Mar 31, 2019):

#419

<!-- gh-comment-id:478344719 --> @tablatronix commented on GitHub (Mar 31, 2019): #419
Author
Owner

@dontsovcmc commented on GitHub (Mar 31, 2019):

I can't image a task where user uses a parameter id. Yeah, minor issuu.

<!-- gh-comment-id:478372482 --> @dontsovcmc commented on GitHub (Mar 31, 2019): I can't image a task where user uses a parameter id. Yeah, minor issuu.
Author
Owner

@tablatronix commented on GitHub (Mar 31, 2019):

Javascript for one

<!-- gh-comment-id:478393150 --> @tablatronix commented on GitHub (Mar 31, 2019): Javascript for one
Author
Owner

@dontsovcmc commented on GitHub (Apr 1, 2019):

wow. 0.1% users?
.setId(const char*) for them.

<!-- gh-comment-id:478398391 --> @dontsovcmc commented on GitHub (Apr 1, 2019): wow. 0.1% users? `.setId(const char*)` for them.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/WiFiManager#726
No description provided.