mirror of
https://github.com/tzapu/WiFiManager.git
synced 2026-04-27 09:05:56 +03:00
[GH-ISSUE #740] Need to fill SSID second time in WebPortal #618
Labels
No labels
📶 WiFi
🕸️ HTTP
Branch
DEV Help Wanted
Discussion
Documentation
ESP32
Example
Good First Issue
Hotfix
In Progress
Incomplete
Needs Feeback
Priority
QA
Question
Task
Upstream/Dependancy
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/WiFiManager#618
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dontsovcmc on GitHub (Sep 23, 2018).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/740
Basic Infos
Hardware
WiFimanager Branch/Release:
Esp8266/Esp32:
Hardware: ESP-12e, esp01, esp25
1.8.0 version of https://github.com/platformio/platform-espressif8266
Description
Run WebPortal and ESP connects to router successful.
ESP connects to router after deep sleep.
Run WebPortal (see SSID name in field) and didn't select SSID, password fields. Change only custom parameters. Press OK.
Debug Messages
Source
I had a lot of additional code and little ESP code.
Additional news:
If I set this
before wm.startConfigPortal( AP_NAME ):
Run ESP startConfigPortal, refill saved SSID, password, push OK.
ESP doesn't connect to router, that has been already connected before.
branch: development
If router turn off ESP connecting failed after timeout correctly.
branch: development
Cyrillic labels shows nice in ConfigPortal.
Idea about Integration tests:
I see a lot of Issues with abnormal behaviour in different modes, routers and some other stuff...
Maybe it possible to create Python/Bash script and ESP test sketch to preserve regression bugs in depending libraries and helps users to check their routers & code?
I think, we can turn on wi-fi active point in linux PC by command line commands, we can talk with ESP by Serial and check it states.
@tablatronix commented on GitHub (Sep 23, 2018):
What do you mean you need to refill, you mean it does not reconnect on save with ssid empty? I think this issue is confusing, I am not sure what you are inferring with the side notes also
@dontsovcmc commented on GitHub (Sep 23, 2018):
If I don't write SSID when I open ConfigPortal, ESP doesn't connect. I think SSID&pwd are saved in memory and need not be filled every time when I open ConfigPortal...
If user should fill SSID every time in ConfigPortal, please don't show previous SSID name in the field.
@tablatronix commented on GitHub (Jan 31, 2019):
#782
@dontsovcmc commented on GitHub (Nov 27, 2019):
@tablatronix it's easy to fill down saved SSID & password to the input web form:
Now you can run Captive Portal for custom parameters changes without refilling SSID & pwd.
I can make pull request if this way ok. I don't know why it wasn't done before.
@tablatronix commented on GitHub (Nov 27, 2019):
Is that not how it already works? What are you trying to solve?
@dontsovcmc commented on GitHub (Nov 28, 2019):
NO!
Now you should write down ssid & password every time you start ConfigPortal.
ESP won't connect:
*WM: No ssid, skipping wifi"Design is terrible". I don't know hidden ESP logic...
If SSID and password saved in ESP, we should show this fact to the user. Not in placeholder.
@tablatronix commented on GitHub (Nov 28, 2019):
What do you mean start configportal?
If they are empty it skips saving, also sending the password back to the web is a security risk
@tablatronix commented on GitHub (Nov 28, 2019):
There is an issue for this I think already
@tablatronix commented on GitHub (Nov 28, 2019):
users are expected to know how esp works already and how it stores credentials.
@dontsovcmc commented on GitHub (Nov 28, 2019):
Hm.. about security I haven't think. Okey, we can send dots to interface value attribute. After Saved we call smth like this:
if (strlen(pwd) == strlen(WiFi_psk()) && pwd.replace('.','').empty()) {
pwd = WiFi_psk();
}
or: type='password' placeholder='password hidden' - so user see, that password already saved in ESP.
After click: if (pwd.empty()) { pwd = WiFi_psk(); }
@tablatronix commented on GitHub (Nov 28, 2019):
I suggest stop using the wifi page to set parameters, and use the setup page now.
@dontsovcmc commented on GitHub (Nov 28, 2019):
I think it's overcode and avoiding the problem. We have a small UX task and you want to increase complexity of library...
@tablatronix commented on GitHub (Nov 30, 2019):
#974
Are you talking to me? It already exists, just change the menu to show setup and it will automatically STOP using the WIFI page for params... This will probably be the default at some point, adding empty ssid checking was complex..
@dontsovcmc commented on GitHub (Nov 30, 2019):
@tablatronix hm..
@tablatronix commented on GitHub (Nov 30, 2019):
Connect to what?
@dontsovcmc commented on GitHub (Nov 30, 2019):
To previously configurated Wi-Fi.
ConfigPortal = /wifi?
@tablatronix commented on GitHub (Nov 30, 2019):
When saving params?
@dontsovcmc commented on GitHub (Nov 30, 2019):
Ok, step by step.
First run startConfigPortal
Fill SSID, Password, click Save
Connect OK. Turn off device.
Second time run startConfigPortal
I see SSID in placeholder, nothing in Password. Click Save.
Connect FAILED. I see
*WM: No ssid, skipping wifi@tablatronix commented on GitHub (Nov 30, 2019):
Mine says its still connected, It never disconnects.
What settings are you using ?
@dontsovcmc commented on GitHub (Nov 30, 2019):
My device is autonomous, so I turn off power after startConfigPortal.
So, If I want to call startConfigPortal second time (after reboot) I should fill password.
p.s. Device connect to wi-fi successfully after reboot, here is no problem.
@tablatronix commented on GitHub (Nov 30, 2019):
ok I see the problem
If
// wm.setBreakAfterConfig(false); (default)and no wifi to save, the portal stays open.The message above is wrong.
Ill make it a little better to understand.
If you want the portal to always close after save, use
wm.setBreakAfterConfig(true);@dontsovcmc commented on GitHub (Nov 30, 2019):
I know, that if connect failed (wrong password) it's also stays open - it's okey.
See this example:
https://github.com/tzapu/WiFiManager/blob/development/examples/ParamsChildClass/ParamsChildClass.ino it's close to my sketch, but I turn off power in the loop.
So, If you run startConfigPortal second time, you should refill password.
@tablatronix commented on GitHub (Nov 30, 2019):
Yeah I need to fix this, setBreakAfterConfig used to do something different than what it said. So its confusing now. Commiting in a few minutes.
@dontsovcmc commented on GitHub (Nov 30, 2019):
Great. For my opinion setShowPassword() is't needed.
@tablatronix commented on GitHub (Nov 30, 2019):
Using param saved page now, We will have to tweak that a bit, maybe auto redirect back to home, or add some more text or back and exit buttons etc
@dontsovcmc commented on GitHub (Nov 30, 2019):
@tablatronix commented on GitHub (Nov 30, 2019):
Closing this because its not really a bug,
Connect FAILED. I see *WM: No ssid, skipping wifimeans skipping wifi connect, has nothing to do with wifi failing. wifi reconnects when you close the configportal