[GH-ISSUE #534] getValue() why not setValue() #446

New issue

Closed

opened 2026-02-28 01:25:20 +03:00 by kerem · 5 comments

kerem commented

2026-02-28 01:25:20 +03:00

Owner

Originally created by @zafrirron on GitHub (Feb 20, 2018).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/534

Probably my misunderstanding...:

Currently from Docs and Examples, handling custom configs done by save config hadler definition and managing FS (json) writes by app developer responsibility.

Since I guess most cases when one uses addParameter method he intend to save it in config, so I would expect this to happen inside the manager by the manager (same like any other wifi params).
In case the app needs to update the config param, I would expect a setValue() method, that would update (and write to FS) the config param.

A derived case is the ability to create, set, update a config params by the app without displaying it in manager config page, so a flag should be available for this.....

Originally created by @zafrirron on GitHub (Feb 20, 2018). Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/534 Probably my misunderstanding...: Currently from Docs and Examples, handling custom configs done by save config hadler definition and managing FS (json) writes by app developer responsibility. Since I guess most cases when one uses addParameter method he intend to save it in config, so I would expect this to happen inside the manager by the manager (same like any other wifi params). In case the app needs to update the config param, I would expect a setValue() method, that would update (and write to FS) the config param. A derived case is the ability to create, set, update a config params by the app without displaying it in manager config page, so a flag should be available for this.....

kerem

2026-02-28 01:25:20 +03:00

closed this issue
added the
enhancement

Documentation

QA
labels

kerem commented

2026-02-28 01:25:21 +03:00

Author

Owner

@tablatronix commented on GitHub (Feb 20, 2018):

yeah i was wondering why no setter, but noticed no ones asked for one.
sounds good

@tablatronix commented on GitHub (Feb 20, 2018): yeah i was wondering why no setter, but noticed no ones asked for one. sounds good

kerem commented

2026-02-28 01:25:21 +03:00

Author

Owner

@tablatronix commented on GitHub (Mar 6, 2018):

This is added to development branch, have you been able to test?

@tablatronix commented on GitHub (Mar 6, 2018): This is added to development branch, have you been able to test?

kerem commented

2026-02-28 01:25:21 +03:00

Author

Owner

@radeonorama commented on GitHub (Sep 30, 2018):

Sorry to bring this one back up but is there an example usage for setValue()?

I want the config page to show the newly saved params and not the default ones and this looks like it might be exactly what i need

@radeonorama commented on GitHub (Sep 30, 2018): Sorry to bring this one back up but is there an example usage for setValue()? I want the config page to show the newly saved params and not the default ones and this looks like it might be exactly what i need

kerem commented

2026-02-28 01:25:21 +03:00

Author

Owner

@zen85 commented on GitHub (May 14, 2020):

Sorry to bring this one back up but is there an example usage for setValue()?

I want the config page to show the newly saved params and not the default ones and this looks like it might be exactly what i need

https://github.com/tzapu/WiFiManager/issues/1050

@zen85 commented on GitHub (May 14, 2020): > Sorry to bring this one back up but is there an example usage for setValue()? > > I want the config page to show the newly saved params and not the default ones and this looks like it might be exactly what i need https://github.com/tzapu/WiFiManager/issues/1050

kerem commented

2026-02-28 01:25:21 +03:00

Author

Owner

@tablatronix commented on GitHub (May 14, 2020):