mirror of
https://github.com/tzapu/WiFiManager.git
synced 2026-04-27 09:05:56 +03:00
[GH-ISSUE #56] Updated lock icon (The small things...) #39
Labels
No labels
📶 WiFi
🕸️ HTTP
Branch
DEV Help Wanted
Discussion
Documentation
ESP32
Example
Good First Issue
Hotfix
In Progress
Incomplete
Needs Feeback
Priority
QA
Question
Task
Upstream/Dependancy
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/WiFiManager#39
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Swiftnesses on GitHub (Jan 10, 2016).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/56
Hi guys,
I've updated the lock icon and specified a size to make it HDPi compatible. Can this be added?
@tzapu commented on GitHub (Jan 11, 2016):
that's such a large icon, wastes about ~5k if i did not count wrongly, a far cry from the ~150bytes the other one was. i tried to make it as small as possible, this being an utilitarian lib, i really want to avoid any unnecessary code to be honest.
is there any chance you could optimise it quite a bit more than that? it surely does not need to be 256x256 for any kind of hdpi display... do try and get it in the 200bytes region though
cheers
@Swiftnesses commented on GitHub (Jan 12, 2016):
My fault, try this on for size:
@tzapu commented on GitHub (Jan 12, 2016):
hi, still seems to be > 5kB ?
@Swiftnesses commented on GitHub (Jan 12, 2016):
Acceptable?
BTW, in an effort to make the font look a little more modern, I also specified a font type on line 28:
@tzapu commented on GitHub (Jan 12, 2016):
huge improvement, will play with it
@tzapu commented on GitHub (Jan 12, 2016):
result:
https://www.dropbox.com/s/x4snbio1wivgmo6/Screenshot%202016-01-12%2014.33.43.png?dl=0
don't want to be nitpicking, but if you can export again, we can shave a few bytes of if you size it to be 26*26px
that way it aligns itself properly with the text as well
@Swiftnesses commented on GitHub (Jan 12, 2016):
The issue is, we're resizing to exactly @2x so it shows correctly on Retina displays, unless we can have an image of 26x26 and specify the size as 13x13?
I never considered that you had an icon for open SSIDs, do we need an icon for them too then?
@tzapu commented on GitHub (Jan 12, 2016):
exactly
this is what works best in my test (alignment and size)
this is what is shown in the screenshot above
@Swiftnesses commented on GitHub (Jan 12, 2016):
I've tried a resize to 26x26 and it looses clarity, I guess due to scaling of the pixels. I think keeping it at 32x32 would be a better option, also allows for easier locating of icons :-)
I presume we just need to adjust the code to correct the alignment...
@tzapu commented on GitHub (Jan 12, 2016):
it s fine then, will update it to this in the next push.
looks nice with 32x32 size and 13x13 in code
thanks for this, i do enjoy the little things
you are also right about the font, worthwhile change
@tzapu commented on GitHub (Jan 12, 2016):
changes added, thanks @markaswift