mirror of
https://github.com/tzapu/WiFiManager.git
synced 2026-04-27 09:05:56 +03:00
[GH-ISSUE #45] DropDown select for WLAN links #34
Labels
No labels
📶 WiFi
🕸️ HTTP
Branch
DEV Help Wanted
Discussion
Documentation
ESP32
Example
Good First Issue
Hotfix
In Progress
Incomplete
Needs Feeback
Priority
QA
Question
Task
Upstream/Dependancy
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/WiFiManager#34
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghost on GitHub (Jan 4, 2016).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/45
It would be netter to use a select instead of links for WLAN selection.
@rpseng commented on GitHub (Jan 7, 2016):
Hi, I also believe an html 'select' would be better.
I can implement that and then send a pull request. My idea was:
Additionally, a small javascript will hide/show the password input whenever the selected network is encrypted or not.
Some feedback should be nice before coding.
All the best.
@tzapu commented on GitHub (Jan 7, 2016):
guys, sorry but i don't favour the dropdowns idea very much...
they would be adding one extra step, be hard to style to show signal quality or encrypted status and so on. they would also look and behave differently in different browsers and/or devices.
i ve always had trouble with dropdowns, not to mention making them look and behave consistently
i think the no scan version already does that. I did not actually test connecting to an unencrypted network, there s a bug that doesn t show me other unecrypted esps, if not all unencrypted networks.
if connecting to an unencrypted network something small to show hide pass field might be interesting
thank you
@rpseng commented on GitHub (Jan 7, 2016):
What about 'radio' buttons then?
@tzapu commented on GitHub (Jan 8, 2016):
radio buttons would be more appropriate, but you'd still add more code for the same end result. (or maybe not if you remove the a elements...)
you could omit the input field, but then you'd have the password field possibly far away from the network selected, or you would have to add a bit of additional javascript to show/hide the password field in the appropriate place.
are you sure the end result is worth the increase in both code and complexity for this?
never had a problem myself with clicking the link and getting it pre populated in the needed field and then just entering the password
i am not against any changes, just wondering how you see the changes benefiting the users
@tzapu commented on GitHub (Jan 8, 2016):
p.s. if you attach a bit of html on how you see the changes i can have a play with it
here s what i used for testing/extracting the html
i wonder if i can add this html template to the repo as well, without it interfering with the arduino lib load process
@ghost commented on GitHub (Jan 8, 2016):
With a little CSS you can make a custom dropdown with a-tags. I can scribble something if you like. I think the UI would get a little smaller. In my case for example i have a terrible long list of networks.
@tzapu commented on GitHub (Jan 8, 2016):
i d be interested to see it, for sure, but if it s css only, i d rather give you the option of setting the css from the main sketch, and then you could taylor it however you would see fit
@tzapu commented on GitHub (Jan 8, 2016):
i ve added the above html to the dev branch
@ghost commented on GitHub (Jan 14, 2016):
Here is my version with a simple select instead of inputs...
WiFiManager.template.html.zip
@tzapu commented on GitHub (Jan 14, 2016):
hi, please don't take my reluctance to move to this as ill intended, but the css alone for the dropdown is adding ~1kB to the library. That's something like 7% of the whole lib, disproportionately big.
icon doesn t seem to work in firefox i think, did not try it on mobile yet, it's also fixed width and makes long network names drop on 2 lines.
the alignment of the signal and lock icon makes it look very clean and nice though
maybe we should decide on a html structure we re happy with, and give you the ability to add your own css. Add the dropdown css in documentation as well, then anyone can decide in their specific case of the memory usage is worth the nicer aspect