[GH-ISSUE #42] add library.json and others files #31

Closed
opened 2026-02-28 01:22:59 +03:00 by kerem · 14 comments
Owner

Originally created by @domonetic on GitHub (Dec 30, 2015).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/42

I added the files to standardize the library.
It allows that in a new update, can be made from the Library Manager.

Originally created by @domonetic on GitHub (Dec 30, 2015). Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/42 I added the files to standardize the library. It allows that in a new update, can be made from the Library Manager.
kerem closed this issue 2026-02-28 01:22:59 +03:00
Author
Owner

@tzapu commented on GitHub (Jan 2, 2016):

thank you very much,
i ll be back in full working order on the 4th and will go through everything asap

<!-- gh-comment-id:168370692 --> @tzapu commented on GitHub (Jan 2, 2016): thank you very much, i ll be back in full working order on the 4th and will go through everything asap
Author
Owner

@tzapu commented on GitHub (Jan 4, 2016):

@domonetic merged the library changes
thank you very much

<!-- gh-comment-id:168672093 --> @tzapu commented on GitHub (Jan 4, 2016): @domonetic merged the library changes thank you very much
Author
Owner

@domonetic commented on GitHub (Jan 4, 2016):

You are welcome. I took the audacity to propose to be included in the Library Manager.
Please go and approves the inclusion

https://github.com/arduino/Arduino/issues/4364#issuecomment-168278446

<!-- gh-comment-id:168689207 --> @domonetic commented on GitHub (Jan 4, 2016): You are welcome. I took the audacity to propose to be included in the Library Manager. Please go and approves the inclusion https://github.com/arduino/Arduino/issues/4364#issuecomment-168278446
Author
Owner

@cmaglie commented on GitHub (Jan 4, 2016):

@tzapu remember also to move the v1.4 tag!

<!-- gh-comment-id:168689792 --> @cmaglie commented on GitHub (Jan 4, 2016): @tzapu remember also to move the v1.4 tag!
Author
Owner

@tzapu commented on GitHub (Jan 4, 2016):

done, thank you again

<!-- gh-comment-id:168689793 --> @tzapu commented on GitHub (Jan 4, 2016): done, thank you again
Author
Owner

@cmaglie commented on GitHub (Jan 4, 2016):

@tzapu remember also to move the v1.4 tag!

ops, I mean "v0.4", basically the library.properties file must appear here:

https://github.com/tzapu/WiFiManager/tree/v0.4

<!-- gh-comment-id:168690437 --> @cmaglie commented on GitHub (Jan 4, 2016): > @tzapu remember also to move the v1.4 tag! ops, I mean "v0.4", basically the library.properties file must appear here: https://github.com/tzapu/WiFiManager/tree/v0.4
Author
Owner

@domonetic commented on GitHub (Jan 4, 2016):

create a new release.

<!-- gh-comment-id:168690979 --> @domonetic commented on GitHub (Jan 4, 2016): create a new release.
Author
Owner

@tzapu commented on GitHub (Jan 4, 2016):

hi, created a new tag, 0.5 and updated the library.json and library.properties files
is it ok?

<!-- gh-comment-id:168692858 --> @tzapu commented on GitHub (Jan 4, 2016): hi, created a new tag, 0.5 and updated the library.json and library.properties files is it ok?
Author
Owner

@cmaglie commented on GitHub (Jan 4, 2016):

Well not yet :-) it seems that you created the new tag before changing library.properties, so the tag 0.5 now points to a library.properties with "version=0.4" written in it.

https://github.com/tzapu/WiFiManager/tree/0.5
https://github.com/tzapu/WiFiManager/blob/0.5/library.properties

to fix this:

  • remove the tag 0.5
  • remake the tag 0.5 on master branch.
<!-- gh-comment-id:168694420 --> @cmaglie commented on GitHub (Jan 4, 2016): Well not yet :-) it seems that you created the new tag **before** changing library.properties, so the tag 0.5 now points to a library.properties with "version=0.4" written in it. https://github.com/tzapu/WiFiManager/tree/0.5 https://github.com/tzapu/WiFiManager/blob/0.5/library.properties to fix this: - remove the tag 0.5 - remake the tag 0.5 on master branch.
Author
Owner

@domonetic commented on GitHub (Jan 4, 2016):

need change version on library.properties, and merge changes in keywords.txt. Please

<!-- gh-comment-id:168695026 --> @domonetic commented on GitHub (Jan 4, 2016): need change version on library.properties, and merge changes in keywords.txt. Please
Author
Owner

@tzapu commented on GitHub (Jan 4, 2016):

ok, updated everything inclusing keywords.txt ( @domonetic somehow the pull request was merged but the keywords still cut off, modified it directly)
thanks

<!-- gh-comment-id:168697052 --> @tzapu commented on GitHub (Jan 4, 2016): ok, updated everything inclusing keywords.txt ( @domonetic somehow the pull request was merged but the keywords still cut off, modified it directly) thanks
Author
Owner

@domonetic commented on GitHub (Jan 4, 2016):

thanks

<!-- gh-comment-id:168700453 --> @domonetic commented on GitHub (Jan 4, 2016): thanks
Author
Owner

@domonetic commented on GitHub (Jan 4, 2016):

Congratulations, now available in the library manager
https://github.com/arduino/Arduino/issues/4364#issuecomment-168714767

<!-- gh-comment-id:168724647 --> @domonetic commented on GitHub (Jan 4, 2016): Congratulations, now available in the library manager https://github.com/arduino/Arduino/issues/4364#issuecomment-168714767
Author
Owner

@tzapu commented on GitHub (Jan 5, 2016):

thank you very much Maximiliano , you did a great job of everything

<!-- gh-comment-id:168902663 --> @tzapu commented on GitHub (Jan 5, 2016): thank you very much Maximiliano , you did a great job of everything
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/WiFiManager#31
No description provided.