[GH-ISSUE #270] Rename setTimeout(...) to be more clear in intent #226

New issue

Closed

opened 2026-02-28 01:24:12 +03:00 by kerem · 1 comment

kerem commented

2026-02-28 01:24:12 +03:00

Owner

Originally created by @cosmocracy on GitHub (Dec 31, 2016).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/270

The concept of "timeout"--without further context in the name--is vague and confusing to consumers of the WifiManager framework. (Timeout of the AP? Timeout waiting for autoconnect? etc.) I suggest you rename this to be clearer and indicate the units of measure. As it stands--and as I understand it--the current method might better be named setConfigPortalTimeoutSec(...). I feel this would alleviate confusion and frustration.

Originally created by @cosmocracy on GitHub (Dec 31, 2016). Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/270 The concept of "timeout"--without further context in the name--is vague and confusing to consumers of the WifiManager framework. (Timeout of the AP? Timeout waiting for autoconnect? etc.) I suggest you rename this to be clearer and indicate the units of measure. As it stands--and as I understand it--the current method might better be named ```setConfigPortalTimeoutSec(...)```. I feel this would alleviate confusion and frustration.

kerem closed this issue

2026-02-28 01:24:12 +03:00

kerem commented

2026-02-28 01:24:12 +03:00

Author

Owner

@tzapu commented on GitHub (Jan 2, 2017):

hi, it was renamed long ago, mentioned in the readme. only left the setTimeout function as well to not break older sketches.

https://github.com/tzapu/WiFiManager#configuration-portal-timeout

thanks

@tzapu commented on GitHub (Jan 2, 2017): hi, it was renamed long ago, mentioned in the readme. only left the setTimeout function as well to not break older sketches. https://github.com/tzapu/WiFiManager#configuration-portal-timeout thanks