mirror of
https://github.com/tzapu/WiFiManager.git
synced 2026-04-27 09:05:56 +03:00
[GH-ISSUE #258] SSID & password sent unsecured #215
Labels
No labels
📶 WiFi
🕸️ HTTP
Branch
DEV Help Wanted
Discussion
Documentation
ESP32
Example
Good First Issue
Hotfix
In Progress
Incomplete
Needs Feeback
Priority
QA
Question
Task
Upstream/Dependancy
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/WiFiManager#215
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pratikpanchal22 on GitHub (Dec 4, 2016).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/258
Configuring the network from the captive portal sends the SSID and APPSK as a GET request to the server running on ESP unsecured. The SSID and APPSK are seen in the url:
http://192.168.4.1/wifisave?s=HomeWifi&p=homeWifi402754This is a security flaw and allows the snoopers to hijack the WiFi credentials very easily.
What would be a feasible solution for that?
@WilliamFrasson commented on GitHub (Dec 6, 2016):
I hope that an https server should ne used instead of the official http server,
I ask to all member...Is it possible?
@cosmocracy commented on GitHub (Dec 20, 2016):
In this case the HTTPS server would have to be run on the ESP8266. The ESP8266 barely supports HTTPS as a client--even then using older TLSv1.1--so I doubt you'll see this capability in the future on the ESP8266 platform. Better to open an issue at the ESP8266 project instead of here.
For reference, see this issue (among the others in the ESP8266 project): https://github.com/esp8266/Arduino/issues/2733
I think this issue is a "non-issue" for WiFiManager for the following reasons:
@tablatronix commented on GitHub (Dec 29, 2016):
It should at least be a post so it is not stored in access logs. Someone made a pull request to do this already ideallly allow both.
@suculent commented on GitHub (Apr 3, 2017):
Yes, this should be a POST from OWASP point of view, regardless transport security.