starred/WiFiManager

Fork 0

mirror of https://github.com/tzapu/WiFiManager.git synced 2026-04-27 17:15:53 +03:00

[GH-ISSUE #22] public and private methods #21

New issue

Closed

opened 2026-02-28 01:22:54 +03:00 by kerem · 6 comments

kerem commented

2026-02-28 01:22:54 +03:00

Owner

Originally created by @domonetic on GitHub (Dec 16, 2015).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/22

I am reviewing the code to help with the wiki and find something I do not understand.
begin () is called by AutoConnect () but is declared public and I think it should be private.

Originally created by @domonetic on GitHub (Dec 16, 2015). Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/22 I am reviewing the code to help with the wiki and find something I do not understand. begin () is called by AutoConnect () but is declared public and I think it should be private.

kerem closed this issue

2026-02-28 01:22:55 +03:00

kerem commented

2026-02-28 01:22:55 +03:00

Author

Owner

@tzapu commented on GitHub (Dec 17, 2015):

yes, you are correct again, leftovers from a past version.
it allwed me then to have an oled connected and do all the steps in the app rather than the library so i can display updates on the screen.
no longer possible, code cleanup is on the table, together with the new callabacks

so nice to see so many people taking interest, thanks

@tzapu commented on GitHub (Dec 17, 2015): yes, you are correct again, leftovers from a past version. it allwed me then to have an oled connected and do all the steps in the app rather than the library so i can display updates on the screen. no longer possible, code cleanup is on the table, together with the new callabacks so nice to see so many people taking interest, thanks

kerem commented

2026-02-28 01:22:55 +03:00

Author

Owner

@domonetic commented on GitHub (Dec 17, 2015):

These have no implementation. It is a virtual method? if I remove works just

String beginConfigMode(void);
void startWebConfig();
String beginConfigMode(void);
int serverLoop();
is used internally, it should not be publicly exposed
String urldecode(const char);*

@domonetic commented on GitHub (Dec 17, 2015): These have no implementation. It is a virtual method? if I remove works just **String beginConfigMode(void); void startWebConfig(); String beginConfigMode(void); int serverLoop();** is used internally, it should not be publicly exposed **String urldecode(const char*);**

kerem commented

2026-02-28 01:22:55 +03:00

Author

Owner

@tzapu commented on GitHub (Dec 17, 2015):

hi, did some cleanup as you indicated.]

urldecode i m gonna leave public, as an utilitarian function for others making url requests

@tzapu commented on GitHub (Dec 17, 2015): hi, did some cleanup as you indicated.] urldecode i m gonna leave public, as an utilitarian function for others making url requests

kerem commented

2026-02-28 01:22:55 +03:00

Author

Owner

@domonetic commented on GitHub (Dec 17, 2015):

Well, I'm helping with the wiki. I hope it will help.

@domonetic commented on GitHub (Dec 17, 2015): Well, I'm helping with the wiki. I hope it will help.

kerem commented

2026-02-28 01:22:55 +03:00

Author

Owner

@tzapu commented on GitHub (Dec 19, 2015):

thank you very much, just seen it, so nice to have

@tzapu commented on GitHub (Dec 19, 2015): thank you very much, just seen it, so nice to have

kerem commented

2026-02-28 01:22:55 +03:00

Author

Owner

@tzapu commented on GitHub (Mar 8, 2016):

there s so much changed, thining at some point the whole things needs another cleanup, then wiki remade
in the mean time, i ll close this

@tzapu commented on GitHub (Mar 8, 2016): there s so much changed, thining at some point the whole things needs another cleanup, then wiki remade in the mean time, i ll close this