mirror of
https://github.com/tzapu/WiFiManager.git
synced 2026-04-28 01:25:49 +03:00
[GH-ISSUE #248] WiFiManager (KT version) traps if no networks found in scan #206
Labels
No labels
📶 WiFi
🕸️ HTTP
Branch
DEV Help Wanted
Discussion
Documentation
ESP32
Example
Good First Issue
Hotfix
In Progress
Incomplete
Needs Feeback
Priority
QA
Question
Task
Upstream/Dependancy
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/WiFiManager#206
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @hutch120 on GitHub (Nov 21, 2016).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/248
@kentaylor I'm not sure if I'm supposed to report this here given your version is a fork?? Anyway, couldn't see a way to mark this issue to your repo.
Your version traps if wifi scan finds no networks.
In the WiFiManager destructor that runs free(networkIndices), the pointer is uninitalised if there were no networks found during the scan.
To fix, initalise the pointer in WiFiManager.h
http://www.cplusplus.com/reference/cstdlib/free/
Cheers,
Simon
@tzapu commented on GitHub (Nov 21, 2016):
feel free to post all stuff here, i see @kentaylor is monitoring issues quite closely
@kentaylor commented on GitHub (Nov 21, 2016):
Thanks @hutch120. I never would have spotted that. Feel free to do a pull request if you spot other stuff. Pull requests work in a fork.
Also thanks @tzapu, you can't have issues in a fork so it is discuss here or nowhere. I've been watching of late but there are long periods where I don't.
@tzapu commented on GitHub (Aug 31, 2017):
hi guys, just wanted to mention it s fine to report here, jsut make sure it's obvious is related to ken's fork
and keep up the good work
cheers