[PR #1768] [MERGED] Do not fill child backgrounds in dark mode #1823

Closed
opened 2026-02-28 02:13:07 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/1768
Author: @dmadison
Created: 10/23/2024
Status: Merged
Merged: 12/11/2024
Merged by: @tablatronix

Base: masterHead: darkmode-background


📝 Commits (1)

  • 06fc439 Do not fill child backgrounds in dark mode

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 wm_strings_en.h (+2 -1)

📄 Description

Small change which allows users to style the body background with dark mode enabled, without having to style the child elements (a, h1) as well.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/1768 **Author:** [@dmadison](https://github.com/dmadison) **Created:** 10/23/2024 **Status:** ✅ Merged **Merged:** 12/11/2024 **Merged by:** [@tablatronix](https://github.com/tablatronix) **Base:** `master` ← **Head:** `darkmode-background` --- ### 📝 Commits (1) - [`06fc439`](https://github.com/tzapu/WiFiManager/commit/06fc43902ddb48c9320462beb64170f8f3b3c15a) Do not fill child backgrounds in dark mode ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `wm_strings_en.h` (+2 -1) </details> ### 📄 Description Small change which allows users to style the body background with dark mode enabled, without having to style the child elements (`a`, `h1`) as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 02:13:07 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/WiFiManager#1823
No description provided.